From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28789 invoked by alias); 30 Mar 2012 16:36:03 -0000 Received: (qmail 28774 invoked by uid 22791); 30 Mar 2012 16:35:59 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Mar 2012 16:35:46 +0000 Received: by iajr24 with SMTP id r24so1524950iaj.0 for ; Fri, 30 Mar 2012 09:35:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.45.229 with SMTP id q5mr1840235igm.62.1333125345253; Fri, 30 Mar 2012 09:35:45 -0700 (PDT) Received: by 10.50.83.37 with HTTP; Fri, 30 Mar 2012 09:35:45 -0700 (PDT) In-Reply-To: <20120329223512.GR2701@adacore.com> References: <1322398359-1364-1-git-send-email-andrew.smirnov@gmail.com> <20120329223512.GR2701@adacore.com> Date: Fri, 30 Mar 2012 16:36:00 -0000 Message-ID: Subject: Re: [PATCH 008/238] Fix Wshadow From: Andrey Smirnov To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg01048.txt.bz2 On Thu, Mar 29, 2012 at 3:35 PM, Joel Brobecker wro= te: >> =A02011-11-19 =A0Andrey Smirnov >> >> + =A0 =A0 * ada-lang.c (ada_make_symbol_completion_list): Rename >> + =A0 =A0 `wild_match' to `wild_match_p'(-Wshadow). >> + >> +2011-11-19 =A0Andrey Smirnov > [...] >> - =A0int wild_match; >> + =A0int wild_match_p; > > The code has changed since you submitted this patch. I am going to > work on a new set of patches that fix this particular type of > warnings... Forgive me if I do not respond to each of the patches > that fix this problem. Yes, unfortunately my patch-set has bit-rotted significantly since the time I submitted the patches and the fact that I used git and the main codebase is in CVS doesn't help either. I wish I had more time to actually go through the code and convert it to be compatible with the new codebase, but unfortunately right now I do not. Best of luck in your endeavor. Hope my old patches would be at least marginally helpful to you. Andrey Smirnov