From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16863 invoked by alias); 24 Nov 2011 04:33:52 -0000 Received: (qmail 16785 invoked by uid 22791); 24 Nov 2011 04:33:50 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gy0-f169.google.com (HELO mail-gy0-f169.google.com) (209.85.160.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Nov 2011 04:33:34 +0000 Received: by ghrr17 with SMTP id r17so2594322ghr.0 for ; Wed, 23 Nov 2011 20:33:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.87.227 with SMTP id bb3mr30819431igb.29.1322109213717; Wed, 23 Nov 2011 20:33:33 -0800 (PST) Received: by 10.50.186.228 with HTTP; Wed, 23 Nov 2011 20:33:33 -0800 (PST) In-Reply-To: References: <878vn88fw3.fsf@gmail.com> <4ECBA525.1010801@redhat.com> <201111221027.52484.vapier@gentoo.org> Date: Thu, 24 Nov 2011 04:33:00 -0000 Message-ID: Subject: Re: [PATCH 22/348] Fix -Wsahdow warnings From: Andrey Smirnov To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00673.txt.bz2 On Thu, Nov 24, 2011 at 12:56 AM, Doug Evans wrote: > For reference sake, I did "grep -e -Wall ChangeLog*" to see what's > been done in the past. =A0Based on that there is room for compromise I th= ink. > > Since these are just mechanical changes, and there are a lot of them, > I'd be happy with a compromise everyone is happy (or at least > not unhappy :-)) with. > > I think keeping them at the file level is easiest for you (just > guessing though). > And I'd be happy with a changelog entry that simply said: > > =A0 =A0 =A0 =A0* foo.c: -Wshadow lint. > > or > > =A0 =A0 =A0 =A0* foo.c (bar, baz): -Wshadow lint. > =A0 =A0 =A0 =A0(huey,dewey,louie): Ditto. > I changed(after it was pointed out that they do not conform to GNU policy) the style of my ChangeLog entries to =A0 =A0 =A0 =A0* 42.c (trillian): Rename zaphod to beeblebrox(-Wshadow). Hope this is a reasonable compromise everyone would be OK with. If anyone have any other suggestions -- I'm all ears. Andrey Smirnov P.S. Just for the future reference, because English is not my first language I expect some of the ChangeLog messages to be awkwardly phrased. If that's the case feel free to nudge me about it and I'll correct it(please do provide suggestions for correction).