From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12175 invoked by alias); 4 Jan 2015 09:35:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12144 invoked by uid 89); 4 Jan 2015 09:35:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ob0-f170.google.com Received: from mail-ob0-f170.google.com (HELO mail-ob0-f170.google.com) (209.85.214.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 04 Jan 2015 09:35:30 +0000 Received: by mail-ob0-f170.google.com with SMTP id wp18so57409794obc.1; Sun, 04 Jan 2015 01:35:28 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.60.175.195 with SMTP id cc3mr47059811oec.10.1420364128511; Sun, 04 Jan 2015 01:35:28 -0800 (PST) Received: by 10.76.153.130 with HTTP; Sun, 4 Jan 2015 01:35:28 -0800 (PST) In-Reply-To: References: <5473A3D3.901@redhat.com> Date: Sun, 04 Jan 2015 09:35:00 -0000 Message-ID: Subject: Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources From: "Bin.Cheng" To: Andrew Pinski Cc: Jeff Law , binutils , "gdb-patches@sourceware.org" , GCC Patches , Ian Lance Taylor Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00033.txt.bz2 On Sun, Jan 4, 2015 at 6:55 AM, Andrew Pinski wrote: > On Mon, Nov 24, 2014 at 1:32 PM, Jeff Law wrote: >> On 11/22/14 21:20, Andrew Pinski wrote: >>> >>> Hi, >>> The problem here is here is that OBJCOPY is not being set to the >>> newly built objcopy when compiling libgo. This patch adds >>> OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when >>> libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET. >>> >>> I noticed this issue when building an aarch64 cross compile on an >>> older system where objcopy did not understand aarch64. >>> >>> OK? Bootstrapped and tested on x86_64 with no regressions. Also >>> tested with a combined build for a cross compiler to >>> aarch64-linux-gnu. >>> >>> Thanks, >>> Andrew Pinski >>> >>> >>> * Makefile.def (flags_to_pass): Pass OBJCOPY_FOR_TARGET also. >>> * Makefile.tpl (HOST_EXPORTS): Add OBJCOPY_FOR_TARGET. >>> (BASE_TARGET_EXPORTS): Add OBJCOPY. >>> (OBJCOPY_FOR_TARGET): New variable. >>> (EXTRA_TARGET_FLAGS): Add OBJCOPY. >>> * Makefile.in: Regenerate. >>> * configure.ac: Check for already installed target objcopy. >>> Also GCC_TARGET_TOOL on objcopy. >>> * configure: Regenerate. >> >> OK > > > Committed to GCC and gdb/binutils repos now. > > Thanks, > Andrew Hi Andrew, > + elif test "x$target" = "x$host"; then > + # We can use an host tool > + OBJCOPY_FOR_TARGET='$(OBJDUMP)' Is it a typo for '$(OBJCOPY)' ? Thanks, bin