From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88468 invoked by alias); 5 Aug 2017 06:38:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79882 invoked by uid 89); 5 Aug 2017 06:38:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=letter X-HELO: mail-lf0-f50.google.com Received: from mail-lf0-f50.google.com (HELO mail-lf0-f50.google.com) (209.85.215.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 05 Aug 2017 06:38:50 +0000 Received: by mail-lf0-f50.google.com with SMTP id d17so14251425lfe.0 for ; Fri, 04 Aug 2017 23:38:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xMCGrD4anDLfwcQ3k8IDGtfPH1XFWm/+ueDrCPgKqvw=; b=fVI053ARuo1LrUDDaNUdzlY4eabSwmt4FQ9p8g7MHvX0sj5sRM7kpmfpN7OX9CH9Ba r8xTyH0rMjTL4lnrtLqqOOSL8n+c+aY2oeDcSwy/4wXpdk6ssMb5yJBnJS25DLhQrIt8 o5UkURws1/cSpUXfKqjg/mLsCyKsQW/s6QWeYFVMdKMujF/bewA2hVzvXrwFo5jml4gf BRoE9PHI2hI0zyp4SuE78OQfm+UDab8YzGwVeLuql+WMV9Y9SP/3tpgFLwwvl8Awyz7e SQzFKzdRrJpDSyUBu5dZMoxWGxMgUtgF0s0FcAEkfvLi2v2lc28ewx0Fq2H0p022wO0K f6CA== X-Gm-Message-State: AIVw110yGDXjhfCy7emD0Zz39g+li/y52Ti85IF8e/g2udaYb7HpZVnb W3DQp4A1ySxj8nq4aqOmrSxbK29/h63v X-Received: by 10.46.76.18 with SMTP id z18mr1664653lja.14.1501915128200; Fri, 04 Aug 2017 23:38:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.201.140 with HTTP; Fri, 4 Aug 2017 23:38:47 -0700 (PDT) In-Reply-To: <83pocawmr7.fsf@gnu.org> References: <1501874838-3067-1-git-send-email-b7.10110111@gmail.com> <83pocawmr7.fsf@gnu.org> From: Ruslan Kabatsayev Date: Sat, 05 Aug 2017 06:38:00 -0000 Message-ID: Subject: Re: [PATCH v2] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00094.txt.bz2 On 5 August 2017 at 09:29, Eli Zaretskii wrote: >> From: b7.10110111@gmail.com >> Cc: Ruslan Kabatsayev >> Date: Fri, 4 Aug 2017 22:27:18 +0300 >> >> From: Ruslan Kabatsayev >> >> Currently, "layout asm" is not so useful as "layout src" with Single-Key mode: >> you have to use multi-key commands like "ni" and "si" to do single-stepping. >> This patch adds, in addition to "next" and "step" commands, corresponding >> assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the >> shortcuts of "o" (from "step Over") and "i" (from "Step Into") respectively. > > The "i" in "nexti" and "ni" stands for "instruction", not "into". Here I refer to the "i" the shortcut, not "i" in the "nexti" command. We do need some way of memorizing the shortcut key, don't we? See the discussion in the thread of the previous version of the patch. I may have to make the wording clearer in the documentation though. > > Personally, I'm not sure this is worth it, but then I don't use TUI > frequently enough to have my opinion count. > > If the code change is accepted, the documentation review is below. > >> gdb/ChangeLog: >> >> * tui/tui.c: Add "nexti" and "stepi" to the tui_commands list >> * doc/gdb.texinfo: Document the new shortcuts in Single-Key mode > > The ChangeLog entries need to state the function/data structure in > which the change is made (node name for the manual). Also, > gdb.texinfo has a separate ChangeLog in gdb/doc/. > >> +@kindex o @r{(SingleKey TUI key)} >> +@item o >> +nexti. The letter @samp{o} stands for ``step Over''. > ^^ > We leave two spaces between sentences. > > Thanks.