From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56487 invoked by alias); 24 Jun 2019 15:12:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56359 invoked by uid 89); 24 Jun 2019 15:12:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy= X-HELO: mail-lf1-f67.google.com Received: from mail-lf1-f67.google.com (HELO mail-lf1-f67.google.com) (209.85.167.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jun 2019 15:12:00 +0000 Received: by mail-lf1-f67.google.com with SMTP id j29so10310897lfk.10 for ; Mon, 24 Jun 2019 08:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NJNyiQYpfJp6p3j2w+7VrrAzbNM9GwveDtGLp7hrycY=; b=kveCyEZOqqxf2Zjt22J2fIQZZ7/1jozXndDDgJFmh0dox85WaBBJ8yJ6ljkr6/A01Y lJvNkec2rSpEq5trrBuD0L88sOwiwr2iNEyRUbOgy6FNyg9uXgfOV5BV0cPPT05At8/i nTEZV9rRT2W2dJS5Ou1z1o4c43GX5bxT6/J4ME2Srs6FBrPqhTVPaljJH80Hy5qz9P5U xRs0rcD8Ll05MlEwQVcWWEpXmO2U5r2GIWibyPme34XmtmPHF0XUs5NkM5+mp8z9FrX6 vlhqwwVvGlDcsjN/g0bbHtqvWUulIXVAmp/DdaYdWINgZAWwfGp4dpsV/yeibNmNGCj5 oVoQ== MIME-Version: 1.0 References: <20190623224329.16060-1-tom@tromey.com> <20190623224329.16060-9-tom@tromey.com> <43b9d2dc-1e03-80f0-da9e-60ea202d3db7@redhat.com> In-Reply-To: <43b9d2dc-1e03-80f0-da9e-60ea202d3db7@redhat.com> From: Ruslan Kabatsayev Date: Mon, 24 Jun 2019 15:12:00 -0000 Message-ID: Subject: Re: [PATCH 08/66] Remove tui_list To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00532.txt.bz2 Hello, On Mon, 24 Jun 2019 at 17:12, Pedro Alves wrote: > > On 6/23/19 11:42 PM, Tom Tromey wrote: > > -static struct tui_list source_windows = {src_win_list, 0}; > > +static struct std::vector source_windows; > > I usually prefer to drop "struct", but I can live with it. > > However, I have to say that "struct std::vector" looks weird. :-) BTW, if you compile a declaration like "struct std::vector source_windows;" with clang++ (with -Wall option), you'll get a warning "struct 'vector' was previously declared as a class [-Wmismatched-tags]", so it's better to either drop the "struct" or change it to "class". > > (There are other instances in the patch.) > > Thanks, > Pedro Alves Regards, Ruslan