From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kJEFE/H/E2JjKAAAWB0awg (envelope-from ) for ; Mon, 21 Feb 2022 16:11:13 -0500 Received: by simark.ca (Postfix, from userid 112) id 33ED01F3CB; Mon, 21 Feb 2022 16:11:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_REPLYTO_END_DIGIT,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7ACDA1EA69 for ; Mon, 21 Feb 2022 16:11:08 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 14E3B385EC59 for ; Mon, 21 Feb 2022 21:11:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14E3B385EC59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1645477868; bh=nCbL2GlvuEiY4rQVM4WSwHmj8A3UjFLp47a629F85dg=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=rNM0UXnUCaCThtpxKpmq7gzD1QrfPtuwNFSI4ri4o4lPgxNlHkKqNzqUGPaQs7rFt OVbwqduRF/YFB8j+aRdBdXogf0Qt0HAq7znsxB+x4JfdfDu9uFZMQ0KMCLWH6gMvaT Nb9OzBKrbHizrpS5cJ1snfA7VGyieh40ZcI+REbs= Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by sourceware.org (Postfix) with ESMTPS id A85553858408 for ; Mon, 21 Feb 2022 21:10:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A85553858408 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-2d68d519a33so150974667b3.7 for ; Mon, 21 Feb 2022 13:10:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=nCbL2GlvuEiY4rQVM4WSwHmj8A3UjFLp47a629F85dg=; b=NCeKPgvIUasIu3+trj0a47G0sEl1xabQVZ/bVwIJ4RSZ8RAjZZvttc4+9DnUKW5BL4 W3Iu+02WghqDLktUXwDIzlmH/izaY0Azjrj4tTI3Rq+Xh5R6CAVLIwhBF1arUntG5thG pBVqe1uRiHvUOor0QUgICwvOZFkTaB3lfygnaR/TRt1RzbA3bwo1Lk1BWPEEcoRerIub 1Gz3JfCcIrTzr4axSkPotQzzjTrNGJ8lTl1ATyMIzeWGQMjHEoga1bI1my0Qn5s9i0UJ 5P5EnQdtimwNnpNdkgc1UymHBpLU66KpbSUufnVAhD1XB2+4vp3RCHWCg1z89587LZTY g7VA== X-Gm-Message-State: AOAM531LvKA1MjpHfwFsPbsT7OLQ/RUT/SHkzsmIlh6q5KqQ+h7OcYbF CFdDjDzDasrAN82wuulnURpeZex0vs7vkMD6nNOUoyld X-Google-Smtp-Source: ABdhPJwg/vUVbGJJ+UPrq+DWGUY+jxdZ6ZeERnO7QjWeQtGjalRkWFTdfx4lVVHQShKbKtyotVTCCAjbu3HK+iYDidk= X-Received: by 2002:a81:c47:0:b0:2d6:beec:b381 with SMTP id 68-20020a810c47000000b002d6beecb381mr16387937ywm.148.1645477845119; Mon, 21 Feb 2022 13:10:45 -0800 (PST) MIME-Version: 1.0 References: <20220211171023.20246-1-b7.10110111@gmail.com> In-Reply-To: <20220211171023.20246-1-b7.10110111@gmail.com> Date: Tue, 22 Feb 2022 00:10:34 +0300 Message-ID: Subject: Re: [PATCH] Fix detection of compilation and linking flags for source-highlight To: GDB Patches Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Ruslan Kabatsayev via Gdb-patches Reply-To: Ruslan Kabatsayev Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Ping! On Fri, 11 Feb 2022 at 20:10, wrote: > > From: Ruslan Kabatsayev > > Currently there are two problems with the detection via pkg-config: > 1. LDFLAGS variable is used to pass --libs to AC_LINK_IFELSE, which > results in the "-L/some/path -lsource-highlight" preceding the > conftest.cpp, which results in failure to find symbol referenced in > conftest.cpp. > 2. CFLAGS variable is used to compile C++ code instead of CXXFLAGS. This > results in --cflags not being passed to the compiler at all. > > This patch fixes both of these mistakes, letting me get a working GDB > with source-highlight installed into a custom prefix ~/opt/gdb-git > (because system repos provide too old version). > --- > gdb/configure.ac | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gdb/configure.ac b/gdb/configure.ac > index 5a380ce38d9..c6fa19b20bc 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -1242,10 +1242,10 @@ either use --disable-source-highlight or dnl > # This situation can occur for instance when using a source highlight > # library compiled with g++ 7.5.0 while building gdb with g++ 4.8.5. > AC_LANG_PUSH(C++) > - save_CFLAGS="$CFLAGS" > - save_LDFLAGS="$LDFLAGS" > - CFLAGS="$CFLAGS $srchigh_pkg_cflags" > - LDFLAGS="$LDFLAGS $srchigh_pkg_libs" > + save_CXXFLAGS="$CXXFLAGS" > + save_LIBS="$LIBS" > + CXXFLAGS="$CXXFLAGS $srchigh_pkg_cflags" > + LIBS="$LIBS $srchigh_pkg_libs" > AC_LINK_IFELSE( > [AC_LANG_PROGRAM( > [#include ], > @@ -1255,8 +1255,8 @@ either use --disable-source-highlight or dnl > [have_usable_source_highlight=yes], > [have_usable_source_highlight=no] > ) > - CFLAGS="$save_CFLAGS" > - LDFLAGS="$save_LDFLAGS" > + CXXFLAGS="$save_CXXFLAGS" > + LIBS="$save_LIBS" > AC_LANG_POP(C++) > > if test "${have_usable_source_highlight}" = "yes"; then > -- > 2.16.2 >