From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24243 invoked by alias); 2 Dec 2015 14:26:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24233 invoked by uid 89); 2 Dec 2015 14:26:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f172.google.com Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 02 Dec 2015 14:26:21 +0000 Received: by obbbj7 with SMTP id bj7so33568405obb.1 for ; Wed, 02 Dec 2015 06:26:19 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.182.55.41 with SMTP id o9mr2998324obp.86.1449066379262; Wed, 02 Dec 2015 06:26:19 -0800 (PST) Received: by 10.202.50.5 with HTTP; Wed, 2 Dec 2015 06:26:19 -0800 (PST) In-Reply-To: <86mvttt7be.fsf@gmail.com> References: <564F998D.5080406@gmail.com> <86mvttt7be.fsf@gmail.com> Date: Wed, 02 Dec 2015 14:26:00 -0000 Message-ID: Subject: Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64 From: Ruslan Kabatsayev To: Yao Qi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-12/txt/msg00035.txt.bz2 Hi Yao, Thanks for your reply. On Wed, Dec 2, 2015 at 2:32 PM, Yao Qi wrote: > I think your patch is correct, but I am not confident approving it > because I know few about floating point stuff. Do you run GDB > regression tests? I did a `make check` for unpatched gdb-7.10 and patched with my changes. Here's the unpatched result: # of expected passes 32377 # of unexpected failures 85 # of unexpected successes 2 # of expected failures 72 # of unknown successes 2 # of known failures 62 # of untested testcases 36 # of unsupported tests 201 And here's after my patch: # of expected passes 32378 # of unexpected failures 85 # of unexpected successes 2 # of expected failures 71 # of unknown successes 2 # of known failures 62 # of untested testcases 36 # of unsupported tests 201 I.e. one "expected failure" less and one "expected pass" more. I'm not sure how to interpret this result. >> gdb/ChangeLog: >> >> * configure.host: Fix detection of x86_64 host when setting floatformats > > This line is too long, the max is 74. Sentence should be ended with ".". Should I resend the whole original mail with this fixed? Regards, Ruslan