From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94215 invoked by alias); 27 Jul 2017 09:12:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93891 invoked by uid 89); 27 Jul 2017 09:11:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f48.google.com Received: from mail-wm0-f48.google.com (HELO mail-wm0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jul 2017 09:11:41 +0000 Received: by mail-wm0-f48.google.com with SMTP id m85so87595686wma.1 for ; Thu, 27 Jul 2017 02:11:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WoASjLTaN1VrvnKIUubq0FQaFIcL2htwtPaM6wFoDys=; b=VPLoCFegD+RDKdlJ3+6TxiceadbD5Dzl9bCwjX+BKNw6K/IiyjK5S6vGtYV2g1aZoR KSFU9rEtNg4lAu6GmXNJ/5Iy9x3fwDgHd9H/uvrjxawR1fW2KpjieSuszWazss/oSH9K uOpst6iSIted7wn36Wt+M3fnvWtw1tAdKW2Kzn0p0ztv5F9WYRywiUbYw2inYI4n2Mh6 CPlTnJxl+7LAM2R4Ifml5P/sFoS/Y/O1XI0hPgxI+KpbriimMtSGuo3rVZj3BolvdOb+ YGXzo73yXAGNaZ1f9PcO9R2kIMcmRsGfO5+Xm25hU6BJmue2V1BJjs6sPajebW7WsIRW q0QQ== X-Gm-Message-State: AIVw112bJHEUFOuGRGHbf+Ji/f2Zy0frlxR4DRXaIH2oC0h4IKsyNU5W hkaAl8vKM7zzWzODsA5dVDlQN3HB/g== X-Received: by 10.28.187.86 with SMTP id l83mr2548707wmf.162.1501146699303; Thu, 27 Jul 2017 02:11:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.126.147 with HTTP; Thu, 27 Jul 2017 02:11:38 -0700 (PDT) In-Reply-To: References: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com> <1be450ee-ea96-76a4-dbf9-81f15b2d4234@gmail.com> <7ee96675bc6f2307642fb638a9b65839@polymtl.ca> From: Ruslan Kabatsayev Date: Thu, 27 Jul 2017 09:12:00 -0000 Message-ID: Subject: Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode To: Simon Marchi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00420.txt.bz2 On 27 July 2017 at 11:19, Simon Marchi wrote: > On 2017-07-27 07:59, Ruslan Kabatsayev wrote: >> >> On 26 July 2017 at 23:53, Simon Marchi wrote: >>> >>> On 2017-07-26 21:19, Ruslan Kabatsayev wrote: >>>> >>>> >>>> So, the patch seems to have been approved by one reviewer (see [1]). But >>>> it >>>> doesn't appear to have been pushed, nor do I have any further >>>> instructions >>>> on how to get it merged. What should I do? >>> >>> >>> >>> Hi Ruslan, >>> >>> The patch is fine with me too, it seems to work well and it's a good >>> idea. >>> >>> It might be a bit more work to implement (an idea for another patch >>> maybe), >>> but do you think it would be nice if n and s did next and step when >>> focusing >>> a source window, but did nexti and stepi when focusing an asm window? >>> When >>> in an asm window, I think you will much more likely want to use >>> nexti/stepi >>> than next/step, so maybe they should be bound to the n and s rather than >>> N >>> and S in that case? >> >> This sounds like a great idea. If this is implemented, do you think N >> and S are then useless and confusing (since n/s would be >> focus-dependent while N/S won't)? > > > I was thinking that perhaps that when focusing... > > a source view: s/n do source line stepping, S/N do assembly stepping > an asm view: s/n do assembly stepping, S/N do source line stepping > > Basically, they would switch role. Is that too confusing? This might be OK, but what if current focus in on registers window? Disable all single-key stepping? > >>> >>> In order to get the patch in, you have two choices: if you plan to >>> contribute more in the future, we can get you write access to the repo, >>> so >>> that you can push your patches in once they are approved. Otherwise, we >>> can >>> push it for you. Let me know what you prefer. >> >> Yes, I do plan to contribute in the future. > > > I'll send you the details in private. > > Thanks, > > Simon