From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27506 invoked by alias); 13 Jun 2012 22:10:08 -0000 Received: (qmail 27454 invoked by uid 22791); 13 Jun 2012 22:10:07 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-lb0-f169.google.com (HELO mail-lb0-f169.google.com) (209.85.217.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 22:09:52 +0000 Received: by lbjn8 with SMTP id n8so1984204lbj.0 for ; Wed, 13 Jun 2012 15:09:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=yW2IrSzW/ptqACh3h4GppXM0TOzyhBhpIatDrXmPV80=; b=M0m8T1qGf8Huk9sacOgUfkCaW+7KfwfS1gmYdZUk5JDw50K0TdpVt7CgSPSxDEIUVD LML65U5OAQ/uyJ5OZeXCWdmO/HQ5Ri+BabHgDuFq7g5d6kN0X5JV0yuIKx7349eyOWkt jyGXXGkYn2pWkRMWD1SmKny5vXepwD9aOZYDzvyKnDClQo57wq4n7sH1oBCSR/ptQdyP nnBMyOkH6YNfxUEtWGOMN9eFdbfhdVDiu7xPPUS7HIBmrVzo3uMgLuhaobkheZKYfC1j +hu2YYSLzRovUrwiitOuNsQ3ou5VFsWYHJl8TY7Y1FG2hJTFElCw1lwdMTWTs/hjleAm 7XIg== Received: by 10.152.135.200 with SMTP id pu8mr16581855lab.8.1339625391047; Wed, 13 Jun 2012 15:09:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.152.135.200 with SMTP id pu8mr16581847lab.8.1339625390899; Wed, 13 Jun 2012 15:09:50 -0700 (PDT) Received: by 10.112.26.101 with HTTP; Wed, 13 Jun 2012 15:09:50 -0700 (PDT) In-Reply-To: References: <87d3558zcz.fsf@fleche.redhat.com> <87txyh7ejn.fsf@fleche.redhat.com> Date: Wed, 13 Jun 2012 22:10:00 -0000 Message-ID: Subject: Re: FYI: fix latent bug in dw2_find_symbol_file From: Cary Coutant To: Doug Evans Cc: Tom Tromey , gdb-patches@sourceware.org, Sterling Augustine Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQnVno+T4myxQ1L3NhyHGtNBEnOC64PpwFlmcWj026mbIjjY0YfnebS8JxUqPBEEDNfyAsLoQu6vGP4K/AehVLB9HijyII9R6j9ys26MgBMibS1prXmvU7LsDkZbSxCD30/2Rug+k1etKwvPeIHjhvU455/DUQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00443.txt.bz2 >>> Doug> You need to call init_cutu_and_read_dies in both debug-types and >>> Doug> non-debug-types cases. =A0When DWO files are in use DW_AT_name li= ves >>> Doug> in the DWO file. =A0OTOH TUs typically don't have DW_AT_name (you >>> Doug> need to look at DW_AT_decl_file). =A0OTOOH this function is only >>> Doug> called by find_main_filename. >>> >>> What gcc branch should I use to test this? >>> And do I need gold? >>> >>> Doug> I'm tempted to rename the routine {,*_}find_function_file (or some >>> Doug> such) and have dw2_find_symbol_file ignore TUs. >>> >>> Fine by me, but I don't plan to do it. >> >> Well, there's only 5 or so places you need to change for the renaming. := -) >> >> What I'm saying is the patch is wrong for TUs but TUs are irrelevant >> here anyway. >> What did you want to test? > > Heh. =A0Monday blues. > [The patch is also wrong for CUs.] > > To test with DWO files you'll need a fission gcc+binutils. > I will let Sterling or Cary suggest what's the best to use. Since only the first of the fission patches has been checked in upstream so far, I'd suggest that the best thing to try is the google/gcc-4_6 branch. There, the fission option is spelled "-gfission" (it'll be "-gsplit-dwarf" when checked in on trunk). I have a branch in my own git repo that's a lot closer to top of trunk, though, and I could push that to the google/debugfission branch in the git mirror if you'd like. -cary