Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Cary Coutant <ccoutant@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Doug Evans <dje@google.com>,
	gdb-patches <gdb-patches@sourceware.org>,
		Sterling Augustine <saugustine@google.com>
Subject: Re: [patch] DWP V2 support
Date: Mon, 30 Sep 2013 19:45:00 -0000	[thread overview]
Message-ID: <CAHACq4piQt0tzG5ySj3YNB+=hRLzCSpb5nLzd4UggW8Kz_PU1w@mail.gmail.com> (raw)
In-Reply-To: <87a9iu9jy0.fsf@fleche.redhat.com>

On Mon, Sep 30, 2013 at 12:40 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> I plan to leave this for a few days for comments, and then commit.
>
> Doug> +/* Possible section ids for version 2 DWP files.
> Doug> +   These values are specified by the DWP spec.  */
> Doug> +
> Doug> +enum dwp_v2_section_ids
> Doug> +{
> Doug> +  DWP_V2_DW_SECT_MIN = 1,
>
> I suspect this is better placed in include/dwarf2.h.
> Presumably some other tool needs this same enum.
>
> Tom

Already there:

/* Codes for the debug sections in a dwarf package (.dwp) file.
   Extensions for Fission.  See http://gcc.gnu.org/wiki/DebugFissionDWP.  */
enum dwarf_sect
  {
    DW_SECT_INFO = 1,
    DW_SECT_TYPES = 2,
    DW_SECT_ABBREV = 3,
    DW_SECT_LINE = 4,
    DW_SECT_LOC = 5,
    DW_SECT_STR_OFFSETS = 6,
    DW_SECT_MACINFO = 7,
    DW_SECT_MACRO = 8,
    DW_SECT_MAX = 8
  };

-cary


  reply	other threads:[~2013-09-30 19:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27 22:44 Doug Evans
2013-09-30 19:41 ` Tom Tromey
2013-09-30 19:45   ` Cary Coutant [this message]
2013-10-01 15:08     ` Tom Tromey
2013-10-05  2:14 ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHACq4piQt0tzG5ySj3YNB+=hRLzCSpb5nLzd4UggW8Kz_PU1w@mail.gmail.com' \
    --to=ccoutant@google.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=saugustine@google.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox