From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9894 invoked by alias); 16 Nov 2016 20:49:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9301 invoked by uid 89); 16 Nov 2016 20:49:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-qk0-f195.google.com Received: from mail-qk0-f195.google.com (HELO mail-qk0-f195.google.com) (209.85.220.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 20:49:20 +0000 Received: by mail-qk0-f195.google.com with SMTP id 124so23058122qkh.1 for ; Wed, 16 Nov 2016 12:49:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=h8vQ1iPA+FlT0nQtIrYMxi0FTxMsunmDV/IHf7xuNJc=; b=RRaTLfrPCHkhqeWq9euNYzvl6daSmuTlqiP/kAPv0Wol3sr+XMSyNAEzQtrrMFKJul xiPyL7Vy0VG5jAw3UWZfzGmvdktuBi844bLBow74sr7hQXgc/kZRxPdw2g0m4/8IoQ/F nZrAjgNvLRklJO86sT2yYzm5RLwdLLocetPHLGtqH1Vf3iXK05DF8eupyQpJomVXe+JW ophH7/prQC94UJR6rPhx79NQw0uzMsYOsrWgT92s0PjIMHkLStXWjSQOr16bGV/FigES JP+gBgCktt7UqRIaqOlHgoLDnb0mFVvxRtmYjBf22SV/Als3sLMEGD/dBUchA7vsmrzQ 3/1Q== X-Gm-Message-State: AKaTC02TBCp4f13+1X18mEte6JO7mcQtoQYkMDfssMoCthxLL7F6zhe47/E/4UpYkChVuDeknuQiolNKcAGsBg== X-Received: by 10.55.101.151 with SMTP id z145mr5563445qkb.35.1479329358929; Wed, 16 Nov 2016 12:49:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.147.238 with HTTP; Wed, 16 Nov 2016 12:49:18 -0800 (PST) In-Reply-To: References: <20161103143300.24934-1-antoine.tremblay@ericsson.com> <20161103143300.24934-6-antoine.tremblay@ericsson.com> <20161110140105.GA31376@E107787-LIN> From: Yao Qi Date: Wed, 16 Nov 2016 20:49:00 -0000 Message-ID: Subject: Re: [PATCH V2 5/5] Support tracepoints for ARM linux in GDBServer To: Antoine Tremblay Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00460.txt.bz2 On Tue, Nov 15, 2016 at 2:36 PM, Antoine Tremblay wrote: >> >> This field is only useful to trap-based tracepoint. It signals that we >> need to create a sub-class trap_based_tracepoint of struct tracepoint. >> > > Currently struct tracepoint is a merged struct if you will of all the > tracepoint types, fast, static, trap. > > Moving to a subclass for trap-based tracepoints, would require making a > subclass for all the others too, static, fast. It would be quite > inconsistent otherwise. Yes, that is what we should do. Before we add something new, we need to clean up the existing code if necessary. > > While I do not object to this change, I think it should be part of > another patch series and that this change is orthogonal to the > tracepoint support for arm. > > WDYT ? > It is not orthogonal to the tracepoint support. In contrary, we must "sub-struct" or "sub-class" tracepoint first, and them add "kind" field for trap-based tracepoint. Note that "struct tracepoint" is used in IPA as well. --=20 Yao (=E9=BD=90=E5=B0=A7)