From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23669 invoked by alias); 27 Oct 2016 15:41:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23659 invoked by uid 89); 27 Oct 2016 15:41:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f172.google.com Received: from mail-qt0-f172.google.com (HELO mail-qt0-f172.google.com) (209.85.216.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Oct 2016 15:41:35 +0000 Received: by mail-qt0-f172.google.com with SMTP id q7so26577077qtq.1 for ; Thu, 27 Oct 2016 08:41:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=u9QNOcBPC6pbu/LaQPwOFu0pQ3V1P/Q20UnFtQU68WY=; b=MXhOoEGSyNBhmrvY3RFoqnFBA9KtYqE7+QYM9r2kyePuXnvY5wLn7xVCy9E86mu8zo Gkoqg9yjBOzprmor3JJU3LaA1volbzz2Z/vJVCJVIH926RMoVY8AYnhAI/Tq9beQ/lpZ KArcLVKyFHoV+KpVqS8d85CK/ALmIlO77+IjYqjrUofZDTLOXCE3DjePRJ6RUrD/OrSY Mk7lvnK1ODf/fDzVqo5GgH0KZ8mgQAQPK06sq8fo7HMRSj7fELhLzg+xiXnMv551YdoF H3TUOFStu+zJ19qRDXRwFIXutstccGfekNXna6HSHHVTuVJEJtcpZFneGdues2ujRuVf dRVw== X-Gm-Message-State: ABUngvfm6hFg+A4cfIFHdDcU0Uq1rQtVs6KrHu+9kJMoKc9Bm2vG7QJ8eMjqfZzHBvlA9gdBpZSZwTmpVL3Cag== X-Received: by 10.200.42.122 with SMTP id l55mr6906655qtl.157.1477582893678; Thu, 27 Oct 2016 08:41:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.149.168 with HTTP; Thu, 27 Oct 2016 08:41:33 -0700 (PDT) In-Reply-To: References: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> From: Yao Qi Date: Thu, 27 Oct 2016 15:41:00 -0000 Message-ID: Subject: Re: [PATCH 00/13] Split brekapoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00768.txt.bz2 Hi Pedro, Thanks for the review, On Thu, Oct 27, 2016 at 3:58 PM, Pedro Alves wrote: > > My only question is what happens to the GDBARCH_BREAKPOINT_MANIPULATION > / SET_GDBARCH_BREAKPOINT_MANIPULATION macros? I was hoping they'd > disappear in the end, but looks like not? (I find the "manipulation" > name to be very opaque here, btw.) Both are the intermediate structure during the the process of conversion. I didn't remove them as I think they two can "simplify" the code, because a lot of gdbarch have one breakpoint instruction. Their breakpoint_kind_from_pc and sw_breakpoint_from_kind look quite similar. --=20 Yao (=E9=BD=90=E5=B0=A7)