From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53520 invoked by alias); 28 Sep 2016 18:42:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53446 invoked by uid 89); 28 Sep 2016 18:42:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=qiyaoltcgmailcom, qiyaoltc@gmail.com, peoples, people's X-HELO: mail-oi0-f51.google.com Received: from mail-oi0-f51.google.com (HELO mail-oi0-f51.google.com) (209.85.218.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Sep 2016 18:42:23 +0000 Received: by mail-oi0-f51.google.com with SMTP id n132so149596oih.1 for ; Wed, 28 Sep 2016 11:42:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ptzMYjsu+dBb4hA7FvdoPYIpFh7owySUeqABzlM7LZ8=; b=jtkqlNa30afCQxkodAx3ZupF1UiHh0CZp6KQTRNr/a6OJY8MXzfak+GDQh1A4dIGbA 7NeF6k7Plb9+MuNu3ryxjfMxwqWewQmXa5CCDLoWsbrsmIDPPnIYfvgamnhK5NJ+4J2C kVq6foyLb9ONbJ4VXotOKHnXDkZgbDUaMqWr1/5JDvvgKjBsLX7W7bm15f5CHlOmJtCg x+AxVgiqX/jwDY0g+owWKth7TqAV+Em4LCChfnWtu5D78BmLWIMFrVGmsCfhgqzKQpqG RdPirWtB6nyVVB0S4TLCSNutsSx+R84mEKiSrb+FBPFdO/vvOsXfcODWvdls/pIKTNxt RMPg== X-Gm-Message-State: AA6/9Rl3oXG1AHmjr2RFxs4AbxE40khFhSsfI09qZBZf95alhfMrseRhi9m2mGsSlcM4M1wYKkdgYtlTNmIO2g== X-Received: by 10.157.53.72 with SMTP id l8mr3823028ote.112.1475088142322; Wed, 28 Sep 2016 11:42:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.237.20 with HTTP; Wed, 28 Sep 2016 11:42:21 -0700 (PDT) In-Reply-To: <8760phcamm.fsf@tromey.com> References: <1475000192-8789-1-git-send-email-tom@tromey.com> <1475000192-8789-2-git-send-email-tom@tromey.com> <8760phcamm.fsf@tromey.com> From: Yao Qi Date: Wed, 28 Sep 2016 21:51:00 -0000 Message-ID: Subject: Re: [RFA 1/3] Fix "fall through" comments To: Tom Tromey Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00403.txt.bz2 On Tue, Sep 27, 2016 at 10:10 PM, Tom Tromey wrote: >>>>>> "Yao" =3D=3D Yao Qi writes: > > Yao> clang has -Wimplicit-fallthrough as well, but warnings are suppresse= d in > Yao> a different way. Do we need to suppress warnings generated by both = gcc > Yao> and clang? > > On my machine, clang won't build gdb. From memory there was at least > some issue compiling .c files in c++ mode, but I think there were other > problems as well. We can use option '-x c++' to suppress the warnings, but you are right, the= re are some other problems, like some warning options are unknown to clang. > > If clang support is desired, then yes, the correct approach is to > replace the fall-through comments with a new attribute. > At least, I don't think of a reason that we don't support clang. clang(++) support is not very good, but we shouldn't make it worse, IMO. I am open to people's thoughts. --=20 Yao (=E9=BD=90=E5=B0=A7)