From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44969 invoked by alias); 26 Oct 2016 15:43:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44951 invoked by uid 89); 26 Oct 2016 15:43:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=architectures, qiyaoltc@gmail.com, qiyaoltcgmailcom X-HELO: mail-qk0-f196.google.com Received: from mail-qk0-f196.google.com (HELO mail-qk0-f196.google.com) (209.85.220.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Oct 2016 15:43:46 +0000 Received: by mail-qk0-f196.google.com with SMTP id o68so526399qkf.4 for ; Wed, 26 Oct 2016 08:43:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=ZsYzYOZBSNDTEl3HEZXN0Xjb3v2HXHuRVxdLPDdh7EQ=; b=ZvwRhfgch5jBb3zTVThqa+DBjcf9tbylvKmOJf0s8468IBYbGdsj9hRKm2BobInRrW eQ3d2r7s4QiOuqcEsd4CZy6H+xmcsAy6dD9MKouM30xFOFoMohWPHvAVXbykKPiWHGs0 wh/I2w6OTG1RIBV4qBvj0RdgBB+3M7mXplF4kUOJaHhMxGVn+1Bx4A3S22MaLK8VrFgT V6F5QmoIRLrjYFCcW9V+ggpupCJMq/0ZZ4aGWG/plpGIMW4dxY7irhE8Te7OeA/l0bvd Vx+Ae1GJ9xBRwdGMei0zPheb14/ceOcovNxnsZFkncrJUeRT7BAPdGbVQAQI/cI6iUdJ AVrg== X-Gm-Message-State: ABUngvdI22AQqm6m5KmurltAcGsgIXOM8gDkFP4O5+idY38X/68DgGEc9RGdP38TC8HcGu+S7K5PxSW2qUbcGQ== X-Received: by 10.55.174.66 with SMTP id x63mr2475332qke.11.1477496624212; Wed, 26 Oct 2016 08:43:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.149.168 with HTTP; Wed, 26 Oct 2016 08:43:43 -0700 (PDT) In-Reply-To: References: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> From: Yao Qi Date: Wed, 26 Oct 2016 15:43:00 -0000 Message-ID: Subject: Re: [PATCH 00/13] Split brekapoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind To: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00723.txt.bz2 On Mon, Oct 10, 2016 at 11:17 AM, Yao Qi wrote: > On Wed, Aug 31, 2016 at 4:05 PM, Yao Qi wrote: >> This patch series is to split gdbarch method brekapoint_from_pc to >> methods breakpoint_kind_from_pc and sw_breakpoint_from_kind. After >> these changes, new gdbarch methods breakpoint_kind_from_pc and >> sw_breakpoint_from_kind are more preferred than brekapoint_from_pc. >> >> In this patch https://sourceware.org/ml/gdb-patches/2016-05/msg00201.htm= l, >> I wanted to remove a global variable arm_override_mode, and the >> discussion leads to a design here >> https://sourceware.org/ml/gdb-patches/2016-07/msg00211.html In short, >> we reuse bp_target_info.placed_size as the "kind" of a breakpoint, >> which can be got by gdbarch breakpoint_kind_from_pc or >> breakpoint_kind_from_current_state. >> >> I choose a way that I can change the code incrementally, and make the >> review easier. Patch #1, #2, #5, and #8 are obvious, IMO. Patch #7 >> and #12 do the major work, and the rest are code refactor. >> >> Regression tested on arm-linux and x86_64-linux. Tests on other >> architectures are welcome! >> > > I've pushed patches 1#, #2, and #5 in, because they are obvious. > Update patch 7 to cover arc. > Ping. --=20 Yao (=E9=BD=90=E5=B0=A7)