From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105554 invoked by alias); 19 Jul 2016 09:47:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105529 invoked by uid 89); 19 Jul 2016 09:47:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1322 X-HELO: mail-oi0-f41.google.com Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 19 Jul 2016 09:47:09 +0000 Received: by mail-oi0-f41.google.com with SMTP id w18so17846749oiw.3 for ; Tue, 19 Jul 2016 02:47:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lHa9bq5bkONGTWmXn7QcInPv40EfNBZx9yoI8mrRnaY=; b=EdssAFQ6Dpb+tDQ9FzzhLGr27XYrg1Ie6LM/xc4oGCgJoJ8fXbIR7HsXFbrPaORtKR 45LohvsN4xGNzfMaP4lXokO2Sl5T0nZ+eozPTC7UZ0pkr0laQvPD63GGnDF49UnpprQx zEBQuX2y2r1O4Z8a432rVskg79Ielejqnt+zg6FJpcmJNO3Xr04l+EUSGezGE9GjvXbU x2ryAAv4Frm8/xoXdtSDoUKcYZdcVxteaKlmZeAY04d1E2H6qKs0R1Jgf4IJq2Xo2I60 NYkXzj6XYTluZP0ovkyhyDoZ0gUI/76KlA0DmfGT5E7p1y3RMWM55DS8n4GyV36Z7O7Z K6xw== X-Gm-Message-State: ALyK8tIdUQWPJClmOm4hJPxiYQbXCOKBy0OsrD0wMZ98y5yED/hABq+P3gqEFJ4JZU4Jujp/wfM7dvClL5OpFw== X-Received: by 10.157.33.125 with SMTP id l58mr23454610otd.32.1468921627600; Tue, 19 Jul 2016 02:47:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.105.138 with HTTP; Tue, 19 Jul 2016 02:47:07 -0700 (PDT) In-Reply-To: <20160718114002.GA26094@host1.jankratochvil.net> References: <20160716131402.GA2961@host1.jankratochvil.net> <20160718081834.GA26110@host1.jankratochvil.net> <20160718114002.GA26094@host1.jankratochvil.net> From: Yao Qi Date: Tue, 19 Jul 2016 09:47:00 -0000 Message-ID: Subject: Re: [testsuite patch] Fix gdb.gdb/selftest.exp for C++-O2-g-built GDB To: Jan Kratochvil Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00199.txt.bz2 On Mon, Jul 18, 2016 at 12:40 PM, Jan Kratochvil wrote: > On Mon, 18 Jul 2016 11:45:36 +0200, Yao Qi wrote: >> OK, I think we still need to convert gdb.gdb/selftest.exp using proc >> do_self_tests to simplify the code, and then, improve procs in >> lib/selftest-support.exp to handle the fails when GDB is compiled with >> optimization. What do you think? If you agree on this, I can commit >> my patch above, and tweak lib/selftest-support.exp to fix your fails. > > I have no opinion on it. I have no idea what's the purpose of > gdb.gdb/selftest.exp . I see during the past 10 years I saw an upstream = catch > of one regression(s) by but it was more an accident and it could happen w= ith > some other regular testsuite-built inferior if it was testing the same > feature. > > I just want to keep it regression-free so do whatever you find fine, I can > rebase my patch on top of it, but I would like no regression for -O2 -g G= DB > and I would like not to carry this patch off-trunk forever. I've pushed my patch in. Your patch changing test_with_self is no longer needed, but changes in do_steps_and_nexts are still useful to fix the fails you've seen, so changes in do_steps_and_nexts are OK to commit. --=20 Yao (=E9=BD=90=E5=B0=A7)