Re: [PATCH 40/40] Document breakpoints / linespec & co improvements (manual + NEWS)

Eli Zaretskii
2017-06-22T19:42:15Z

> Cc: gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Wed, 21 Jun 2017 16:50:24 +0100
>
> +A likely situation where you might need this is in typing an
> +expression that involves a C@t{++} symbol name with template
> +parameters. This is because when completing expressions, GDB treats
^^^
@value{GDBN}

> +See @ref{quoting names} for a description of other scenarios that
^^^^^^^^
This is OK, but @xref does the same job. In any case, it is good
practice to put a comma after the closing brace, or else some versions
of makeinfo will bitch at you.

> +For example, assuming a program with symbols named @code{A::B::func}
> +and @code{B::func}, both commands @code{break -function func} and
> +@code{break -function B::func} set a breakpoint on both symbols.
> +
> +@item -qualified @var{function}
> +Like @code{-function}, but the value specifies a fully qualified name
> +of a function.
> +
> +For example, assuming a C@t{++} program with symbols named

Two "For example" too close to one another. Suggest to replace the
2nd one with "As another example".

> +@code{A::B::func} and @code{B::func}, the @code{break -qualified
> +B::func} command ^^^^^^^^^^^^^^^^^^^^^^
^^^^^^^^
This is better put in @w{..}.

> +
> @item -label @var{label}
> The value specifies the name of a label. When the function
> name is not specified, the label is searched in the function of the currently
> @@ -14992,6 +15035,49 @@ the same notation that is used to declare such symbols in C@t{++}: type
> also use the @value{GDBN} command-line word completion facilities to list the
> available choices, or to finish the type list for you.
> @xref{Completion,, Command Completion}, for details on how to do this.
> +
> +@item @r{Breakpoints in functions with ABI tags}
> +
> +The GNU C@t{++} compiler introduced the notion of ABI ``tags'', which

"tags" should be in @dfn (which will produce the quotes, so you can
lose them). Also, I'd add a @cindex entry here about "ABI tags".

> +when compiled for the C++11 ABI is marked with the @code{cxx11} ABI
^^^^^
C@t{++}11, I think.

> +tag, and @value{GDBN} displays the symbol like this:
> +
> +@smallexample
> +function[abi:cxx11](int)
> +@end smallexample

Where does GDB use this format? Only in "info break", as shown below,
or also in other contexts? If the latter, I suggest that the above
example show some full output with context.

The patch is OK with those fixed.

Thanks.