Re: [pushed] Re: [PATCH 36/40] Add comprehensive C++ operator linespec/location/completion tests

Pedro Alves
2017-11-30T16:06:01Z

On 11/30/2017 03:43 PM, Yao Qi wrote:
> On Sat, Nov 25, 2017 at 12:18 AM, Pedro Alves <palves@redhat.com> wrote:
>>
>> Great, and a much belated thanks.
>>
>> and that this one works with current master already, so I've
>> pushed it in, as below.
>>
>
> Hi Pedro,
> some of these tests fail on some buildslsaves,
>
> https://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/8122/steps/test%20gdb/logs/stdio
> https://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-m32/builds/2219/steps/test%20gdb/logs/stdio
> https://gdb-build.sergiodj.net/builders/Fedora-i686/builds/8145/steps/test%20gdb/logs/stdio
>

Thanks. Hmm, 32-bit builds. I can reproduce this locally with -m32...

(gdb) complete b -function test_op_delete_array::operator delete [] ( void * ) -sour
b -function test_op_delete_array::operator delete [] ( void * ) -source
(gdb) PASS: gdb.linespec/cpls-ops.exp: operator-delete[]: cmd complete "b -function test_op_delete_array::operator delete [] ( void * ) -sour"
b test_op_new::operator new(unsigned int) FAIL: gdb.linespec/cpls-ops.exp: operator-new: tab complete "b test_op_new::operator" (timeout)
^CQuit
(gdb) complete b test_op_new::operator
b test_op_new::operator new(unsigned int)
(gdb) FAIL: gdb.linespec/cpls-ops.exp: operator-new: cmd complete "b test_op_new::operator"
b test_op_new::operator new(unsigned int) got a INT signal, interrupted by user

Looks like I considered the possibility of different size_t typedefs
at some point but didn't really address it fully:

proc test_operator_new {class_name brackets} {
# The type size_t is typedef-ed to.
set size_t "unsigned long"

I'll fix this when I have a chance.

Thanks,
Pedro Alves