From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71981 invoked by alias); 26 Oct 2016 20:14:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71966 invoked by uid 89); 26 Oct 2016 20:14:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:826, controlling X-HELO: mail-qk0-f196.google.com Received: from mail-qk0-f196.google.com (HELO mail-qk0-f196.google.com) (209.85.220.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Oct 2016 20:14:47 +0000 Received: by mail-qk0-f196.google.com with SMTP id n189so978986qke.1 for ; Wed, 26 Oct 2016 13:14:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JW6iOOoEUdvbNjs/CFfVIPUe6W4AiQooGVQpzUzm+2k=; b=PFEMvojRNDgae85ShMF4pqGfUdX/aYmJ2UI90LjTcWdDZD92EsF6Z/7U9A75ePbULn 5FzC5UxgKSW2R047tGGsg7ICMvF75bXZc/OyAkaXHefUqaOwhdctamB5qWposIWDv7BW DOwsuf2uKdgdVcRpcuxWWIpUdnImn8lIYmYkl0ORV1j3Etld8LtLr59QklSYskR7alo8 T5lA9U1zoJTMRDRZ7WHPl7yTLBXg+3FYvJi2aJkbBkusQue4TJlIbPSFe0fKw/lnTFZ2 cChf/8OszPGhCpTOp9L0M36sGq9n+M17BnljiVLptVOVuzJYo2XjiKKS/rIAvtCEvOU3 SY7w== X-Gm-Message-State: ABUngvcPlxQZi6C1wFqkO1Px8fUyr+KCOxYiJxJjtjjWWygqIYsfervOTx1Pi4i8zz7dPfbw5mHqjm9EwW+EkA== X-Received: by 10.55.101.151 with SMTP id z145mr2938999qkb.35.1477512885719; Wed, 26 Oct 2016 13:14:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.149.168 with HTTP; Wed, 26 Oct 2016 13:14:45 -0700 (PDT) In-Reply-To: References: <1474856716-5913-1-git-send-email-yao.qi@linaro.org> <1474856716-5913-2-git-send-email-yao.qi@linaro.org> From: Yao Qi Date: Wed, 26 Oct 2016 20:14:00 -0000 Message-ID: Subject: Re: [PATCH 1/3] Remove single-step breakpoint for GDBserver internal event To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00729.txt.bz2 On Wed, Oct 26, 2016 at 1:45 PM, Pedro Alves wrote: > On 09/26/2016 03:25 AM, Yao Qi wrote: >> This patch removes single-step breakpoints if the event is only >> GDBserver internal, IOW, isn't reported back to GDB. > > Can you expand on rationale? Why does being internal matter? We remove single-step breakpoints on the moment we report event back to GDB. However, if we use single-step breakpoints and get some events, we don't report them back to GDB and keep controlling the inferior, we need to remove single-step breakpoints. For example, in range stepping, until the program goes out of the range, we keep doing single step (by software), in a loop of insert single-step breakpoints, resume, remove them. --=20 Yao (=E9=BD=90=E5=B0=A7)