From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87553 invoked by alias); 17 Oct 2016 20:09:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87533 invoked by uid 89); 17 Oct 2016 20:09:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-oi0-f51.google.com Received: from mail-oi0-f51.google.com (HELO mail-oi0-f51.google.com) (209.85.218.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Oct 2016 20:08:52 +0000 Received: by mail-oi0-f51.google.com with SMTP id d132so226099085oib.2 for ; Mon, 17 Oct 2016 13:08:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ksVsp9Bdh4JMt+iwvUtskPAYt3q3uDao3/VB9iNVh6M=; b=iJoMDFaLzvTLG1OtFLM6tRXB+sjfvyCnrHC0uXcUM90vD4mq4XTNRNGR0M6cq/o+GH 0bMsv+bz6vAbSjfOrwe3Nci2+v5Z+u6b1/vkibD4ozL0TFBDK96/Ttfi+6uts1tGvfDJ LglOsPWOMiWn/LZ82BvAi2JTexWPo5zPGAF+PS068XsQxlzGB8dMeurE+Y2LapexWHfs 5w39aR9t1Tfz8ldFzmqujP2ufnsHD/obFgTPR0T5MoRVXGzwvd3QXfloSBVwgbMCdLKh yNwjbGBqxehtwqG70SDTCo1LIJ6AndtM7er6+zbm4srD+PhauIKGg8SrQzk59DkKk3PZ i5Eg== X-Gm-Message-State: AA6/9RmClPykGFawiirRdZNh9mqURw6yUPZmhFv8cbkAk1mupCqyod397PjheHIT3j1V6Z3oSfSCAdrMarJEEQ== X-Received: by 10.202.104.222 with SMTP id o91mr4443045oik.31.1476734930807; Mon, 17 Oct 2016 13:08:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.193.5 with HTTP; Mon, 17 Oct 2016 13:08:50 -0700 (PDT) In-Reply-To: <20161014202536.21670-1-simon.marchi@ericsson.com> References: <20161014202536.21670-1-simon.marchi@ericsson.com> From: Yao Qi Date: Mon, 17 Oct 2016 20:09:00 -0000 Message-ID: Subject: Re: [PATCH] Fix -trace-save crash when argument is missing To: Simon Marchi Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00489.txt.bz2 HI Simon, Patch is good to me. A nit below, On Fri, Oct 14, 2016 at 4:25 PM, Simon Marchi w= rote: > + > + if (oind >=3D argc) Nit: if (argc - oind !=3D 1) > + error (_("Argument required (file in which to save trace data)")); > + > filename =3D argv[oind]; > --=20 Yao (=E9=BD=90=E5=B0=A7)