From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Jonah Graham <jonah@kichwacoders.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] bound_registers.py: Add support for Python 3
Date: Wed, 22 Mar 2017 09:16:00 -0000 [thread overview]
Message-ID: <CAH=s-PP9_yR38hJs4mQj5YKs-ZadKh6fNai=+tCMQR=iGkeDUQ@mail.gmail.com> (raw)
In-Reply-To: <cfe9a625-551b-beba-5a77-96d21a84c010@redhat.com>
On Fri, Mar 17, 2017 at 3:00 PM, Pedro Alves <palves@redhat.com> wrote:
> diff --git a/gdb/python/lib/gdb/printer/bound_registers.py b/gdb/python/lib/gdb/printer/bound_registers.py
> index b315690..104ea7f 100644
> --- a/gdb/python/lib/gdb/printer/bound_registers.py
> +++ b/gdb/python/lib/gdb/printer/bound_registers.py
> @@ -16,6 +16,11 @@
>
> import gdb.printing
>
> +if sys.version_info[0] > 2:
> + # Python 3 removed basestring and long
> + basestring = str
> + long = int
> +
This change causes some fails in gdb.python/py-pp-maint.exp,
disable pretty-printer^M
6 printers disabled^M
0 of 6 printers enabled^M
(gdb) FAIL: gdb.python/py-pp-maint.exp: disable pretty-printer
looks the number of pretty-printer is changed. Without this patch,
there are 7 pretty-printers,
info pretty-printer^M
global pretty-printers:^M
builtin^M
mpx_bound128^M
lookup_function_lookup_test^M
pp-test^M
enum flag_enum^M
s^M
ss^M
struct s^M
struct ss^M
(gdb) PASS: gdb.python/py-pp-maint.exp: info pretty-printer
but with this patch applied, it becomes 6, mpx_bound128 is
disappeared.
info pretty-printer^M
global pretty-printers:^M
builtin^M
lookup_function_lookup_test^M
pp-test^M
enum flag_enum^M
s^M
ss^M
struct s^M
struct ss^M
(gdb) PASS: gdb.python/py-pp-maint.exp: info pretty-printer
I'll look into this problem further.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-03-22 9:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 20:47 Jonah Graham
2016-11-20 20:51 ` Jonah Graham
2016-11-23 16:59 ` Luis Machado
2016-11-23 22:40 ` Jonah Graham
2016-11-23 23:04 ` Luis Machado
2016-11-23 23:10 ` Jonah Graham
2016-11-26 16:28 ` Jonah Graham
2016-11-26 18:55 ` Jonah Graham
2016-11-26 18:55 ` Jonah Graham
2016-11-26 21:27 ` Luis Machado
2017-03-08 8:35 ` Jonah Graham
2017-03-17 15:00 ` Pedro Alves
2017-03-22 9:16 ` Yao Qi [this message]
2017-03-22 9:38 ` Jonah Graham
2017-03-22 11:26 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PP9_yR38hJs4mQj5YKs-ZadKh6fNai=+tCMQR=iGkeDUQ@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jonah@kichwacoders.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox