Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Replace operator new / operator new[]
Date: Fri, 23 Sep 2016 09:49:00 -0000	[thread overview]
Message-ID: <CAH=s-PP0NaFO+EsZEEnoGpKMQJc03i1MR9ATaoLuKKZz0Gw0JA@mail.gmail.com> (raw)
In-Reply-To: <1474543227-19614-1-git-send-email-palves@redhat.com>

On Thu, Sep 22, 2016 at 12:20 PM, Pedro Alves <palves@redhat.com> wrote:
> diff --git a/gdb/common/new-op.c b/gdb/common/new-op.c
> new file mode 100644
> index 0000000..c3b73c1
> --- /dev/null
> +++ b/gdb/common/new-op.c
> @@ -0,0 +1,85 @@
> +/* Replace operator new/new[], for GDB, the GNU debugger.

Patch is good to me.  One comment on file name suffix, did you consider
.cc suffix?

-- 
Yao (齐尧)


  reply	other threads:[~2016-09-23  9:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 13:39 Pedro Alves
2016-09-23  9:49 ` Yao Qi [this message]
2016-09-23 16:14   ` Pedro Alves
2016-09-23 16:37     ` Yao Qi
2016-09-23 19:53       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH=s-PP0NaFO+EsZEEnoGpKMQJc03i1MR9ATaoLuKKZz0Gw0JA@mail.gmail.com' \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox