Re: [PATCH 6/8] const-fy regcache::m_aspace

Simon Marchi
2017-10-31T14:19:35Z

On 2017-10-27 05:31 AM, Yao Qi wrote:
> regcache::m_aspace is a const, never changed during the lifetime of
> regcache object.

I don't really understand what this patch tries to achieve. From the
description above, I thought you wanted to make the m_aspace field const,
not the pointed object.

If constifying the pointed address_space object is really what you meant to
do, I find having the const_cast more confusing than anything else. I think
we should constify all the way (removing const_casts, putting more consts
where needed) or not at all.

Simon