Re: [testsuite patch] Fix gdb.gdb/selftest.exp for C++-O2-g-built GDB

Yao Qi
2016-07-19T09:47:12Z

On Mon, Jul 18, 2016 at 12:40 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Mon, 18 Jul 2016 11:45:36 +0200, Yao Qi wrote:
>> OK, I think we still need to convert gdb.gdb/selftest.exp using proc
>> do_self_tests to simplify the code, and then, improve procs in
>> lib/selftest-support.exp to handle the fails when GDB is compiled with
>> optimization. What do you think? If you agree on this, I can commit
>> my patch above, and tweak lib/selftest-support.exp to fix your fails.
>
> I have no opinion on it. I have no idea what's the purpose of
> gdb.gdb/selftest.exp . I see during the past 10 years I saw an upstream catch
> of one regression(s) by but it was more an accident and it could happen with
> some other regular testsuite-built inferior if it was testing the same
> feature.
>
> I just want to keep it regression-free so do whatever you find fine, I can
> rebase my patch on top of it, but I would like no regression for -O2 -g GDB
> and I would like not to carry this patch off-trunk forever.

I've pushed my patch in. Your patch changing test_with_self is no longer
needed, but changes in do_steps_and_nexts are still useful to fix the fails
you've seen, so changes in do_steps_and_nexts are OK to commit.

--
Yao (齐尧)