From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simark@simark.ca>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/7 v2] Class-fy partial_die_info
Date: Mon, 26 Feb 2018 15:39:00 -0000 [thread overview]
Message-ID: <CAH=s-POPhXes+o+No3H6o3LuR0W3wkxegQYvAdQ6EfETY+jAbw@mail.gmail.com> (raw)
In-Reply-To: <2e05d08d-9e11-40fe-05d1-25a093a6cd47@simark.ca>
On Sun, Feb 25, 2018 at 11:52 PM, Simon Marchi <simark@simark.ca> wrote:
>
> I went through the series again, I sent a comment on patch 2,
> otherwise LGTM.
>
Thanks for the review, Simon. Patch 2 is updated per your comment. I
pushed them in.
--
Yao (齐尧)
prev parent reply other threads:[~2018-02-26 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 15:36 Yao Qi
2018-02-22 15:36 ` [PATCH 2/7] Don't check abbrev is NULL in read_partial_die Yao Qi
2018-02-25 23:33 ` Simon Marchi
2018-02-22 15:36 ` [PATCH 4/7] Class-fy partial_die_info Yao Qi
2018-02-22 15:36 ` [PATCH 6/7] Move fixup_partial_die to partial_die_info::fixup Yao Qi
2018-02-22 15:36 ` [PATCH 3/7] Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die Yao Qi
2018-02-22 15:36 ` [PATCH 7/7] Move read_partial_die to partial_die_info::read Yao Qi
2018-02-22 15:36 ` [PATCH 5/7] Remove one argument abbrev_len in read_partial_die Yao Qi
2018-02-22 15:36 ` [PATCH 1/7] Re-write partial_die_info allocation in load_partial_dies Yao Qi
2018-02-25 23:52 ` [PATCH 0/7 v2] Class-fy partial_die_info Simon Marchi
2018-02-26 15:39 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-POPhXes+o+No3H6o3LuR0W3wkxegQYvAdQ6EfETY+jAbw@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox