From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38181 invoked by alias); 4 Oct 2016 16:08:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38161 invoked by uid 89); 4 Oct 2016 16:07:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f48.google.com Received: from mail-oi0-f48.google.com (HELO mail-oi0-f48.google.com) (209.85.218.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Oct 2016 16:07:58 +0000 Received: by mail-oi0-f48.google.com with SMTP id n132so175620150oih.1 for ; Tue, 04 Oct 2016 09:07:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Tr1h2/Yi22UadWVODcpODr1rkmMjh2eyF7ePQI+CxjM=; b=MbHAhCvcLOAECSdppFSAnh7vwhxSkSP7poYWtTCisAH8d1hoEwTxeW5Z2TNTNF32YI wbgv9IM6+xByv9EMieNVV0JpDpLooTOwKO5NimmVTPZftNPx9WCoxcz6nck/p51j9NU4 f1Zc1dj7AtnPpfq6Dcu2HTi38BSj7a/cO1pxOKUtLqkOm/j+Uve5/OOTQuCRXPxBAIy5 Lq9MMG5TCtBinPZGFhs9GaLnsQGyBqIecZ/aKGXAY4UHvh6ViEekhRTqiwVc/3RJrZ2A cljLo1Lio3rLsmYlaCE2PmrmWKoo9kj5Ivc0Z5Ae5wbkuU4+tIO2tlTpfgJlGg2o3aEv RATg== X-Gm-Message-State: AA6/9RklWVAOr/y/DiQv+gQQp+gnAtjZf96qqLNuHW6W1qIDR++tAb5tSn/AgG6194aW7FnIFwKxXyWzkNc9vg== X-Received: by 10.202.4.17 with SMTP id 17mr3811059oie.91.1475597276989; Tue, 04 Oct 2016 09:07:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.221.3 with HTTP; Tue, 4 Oct 2016 09:07:56 -0700 (PDT) In-Reply-To: <20161003203500.GA2251@host1.jankratochvil.net> References: <20161003203500.GA2251@host1.jankratochvil.net> From: Yao Qi Date: Tue, 04 Oct 2016 16:08:00 -0000 Message-ID: Subject: Re: [testsuite patch] Fix recent GCC FAIL: gdb.arch/i386-signal.exp To: Jan Kratochvil Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00045.txt.bz2 On Mon, Oct 3, 2016 at 9:35 PM, Jan Kratochvil wrote: > The two attached patch chunks each fixes the FAIL on its own. > > The .exp patch is an obvious typo fix I think. The regex was written to > accept "ADDR in main" and I find it OK as checking .debug_line validity i= s not > the purpose of this testfile. > This is reasonable to me. > The .c patch will properly create a new corresponding source line .debug_= line > entry for the 'mov $0x0,%eax' instruction and I also do not think it is > relevant to the purpose of this testfile. > Why do we need the second one? --=20 Yao (=E9=BD=90=E5=B0=A7)