From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96687 invoked by alias); 4 Jul 2017 10:20:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96663 invoked by uid 89); 4 Jul 2017 10:20:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f196.google.com Received: from mail-qt0-f196.google.com (HELO mail-qt0-f196.google.com) (209.85.216.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Jul 2017 10:20:14 +0000 Received: by mail-qt0-f196.google.com with SMTP id m54so23947238qtb.1 for ; Tue, 04 Jul 2017 03:20:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kXlfL0bWw0zf+iBGUTA7v4iM7H/medH4fJg/WvEqu0I=; b=MH3TZOP1XtyT10YpucXBKIKL1mO1ZqGHzdPx4RdPxGsnkN4ligLWL0NJvjti6Q+rF6 QlvRYj4sKsgze1dADjfCSq516n2L+eBkQoJjJoIvRaMVZ6WqEb2GUD5Y9D4uuREw4GBg 8qjsHlY+tJBr7je7g1Ep2iK1Bm3hkmW2A8RVkQKJPeTm5USklXFwAiH72t7l9NX9AnpT jPVVzurUy7ifaljn020T954x9U/9Y/C7Bu18Nt9YaB8Lsem8Vx4bL/d3b3DmyfNtV34X eqTSrdz6J0ePM+r5dwwNmFQtmlqkFGAspb++xchMDLiOxyFVUJPYOgmE2k94qKZwYKPe RgfQ== X-Gm-Message-State: AKS2vOy2xXMlWCtPxad3URwrGjbpvLpfm+YO0YFjkDZhZfVYR67FFQKW 1PeYxcQ/cPtJzcQ62+wS47sYg+H8qQ== X-Received: by 10.200.46.100 with SMTP id s33mr50841590qta.48.1499163612867; Tue, 04 Jul 2017 03:20:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.142.67 with HTTP; Tue, 4 Jul 2017 03:20:12 -0700 (PDT) In-Reply-To: <20170703162737.8386-1-Anton.Kolesov@synopsys.com> References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> From: Yao Qi Date: Tue, 04 Jul 2017 10:20:00 -0000 Message-ID: Subject: Re: [PATCH] Import setenv and unsetenv from gnulib To: Anton Kolesov Cc: "gdb-patches@sourceware.org" , Francois Bedard , Sergio Durigan Junior Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00017.txt.bz2 On Mon, Jul 3, 2017 at 5:27 PM, Anton Kolesov wrote: > This patch supersedes > https://sourceware.org/ml/gdb-patches/2017-07/msg00009.html > > --- > > Patch [1] broke a build on MinGW hosts, because MinGW doesn't provide POS= IX > functions setenv () and unsetenv (). This can be fixed by using > implementations from gnulib. > > [1] https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcommit;h=3D9a6c7= d9c0 > We need commit hash and subject only, like 9a6c7d9c0 (C++ify gdb/common/environ.c) Did you run regression test on x86-linux? If there is no regression, patches is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)