From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97257 invoked by alias); 18 Oct 2016 20:17:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97248 invoked by uid 89); 18 Oct 2016 20:17:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=presently X-HELO: mail-oi0-f43.google.com Received: from mail-oi0-f43.google.com (HELO mail-oi0-f43.google.com) (209.85.218.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Oct 2016 20:16:54 +0000 Received: by mail-oi0-f43.google.com with SMTP id t73so6361507oie.1 for ; Tue, 18 Oct 2016 13:16:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DQ21Sf2UGn+6p0DUGvfOUEdUPSjePctBa7J2vaoVoKE=; b=QQDb1xMmSKLL+oNEpdQE4s33cOBIQY37LZ9aNizEJQIaxly3dg2MBt1xJLnFL5yFhO Hl6dOfitnrsHXCCwKpaMD+F8eacEuTxI6soeWg7Bt6iSFE7ctFc1nA7iVhoaJxR9fUcv MPvstO8Ebdn844Ysd6iYPHmS/uQGEcB2WmqGaJ059QiUlP2A3LSv+N+sKTWyYtvigMRh YZG8sD99y0aobLdMjulTH+KmwbUDoCqw1aWlbfqxnGf9wZdq9CvuWC34m0sMN6dqrd9d qF5Cs/W0Ca+l9xhi9+fVopIzWmP85zu4AK7FctQruGyZdTTNUesRRThTzknxSPJGprk4 DYxA== X-Gm-Message-State: AA6/9RlBB82XqrItn+AKP/lZURfvNibb3afypRi9KD31eeSzZFdl8a+bXztEUqg71WX1qE2aej4s0/CQEKmVhA== X-Received: by 10.157.14.24 with SMTP id c24mr1367440otc.244.1476821812912; Tue, 18 Oct 2016 13:16:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.193.5 with HTTP; Tue, 18 Oct 2016 13:16:52 -0700 (PDT) In-Reply-To: <57CF117B.5040106@codesourcery.com> References: <57CF117B.5040106@codesourcery.com> From: Yao Qi Date: Tue, 18 Oct 2016 20:17:00 -0000 Message-ID: Subject: Re: [patch, rfa] tweak to defaulted_query logic to fix gdb.mi test errors To: Sandra Loosemore Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00520.txt.bz2 On Tue, Sep 6, 2016 at 2:56 PM, Sandra Loosemore wrote: > This patch moves the check for deprecated_query_hook before > input-not-from-terminal check in defaulted_query, instead of after it. > Presently, the only thing that uses deprecated_query_hook is the MI backe= nd, > which uses it to suppress the question entirely, so that the current > behavior leads to the situation where nothing is printed when the input i= s a > terminal but there is a message otherwise, which is somewhat odd. > > The specific problem this patch solves is a testing issue with gdbserver. > mi_gdb_target_load says: > > mi_gdb_test "kill" ".*" "" > > and if the test harness is not running GDB from a terminal we get: > Can you "set interactive-mode on" in your test? I read your patch several times, I am not sure we need this patch. --=20 Yao (=E9=BD=90=E5=B0=A7)