From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63231 invoked by alias); 21 Feb 2018 08:27:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63221 invoked by uid 89); 21 Feb 2018 08:27:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f177.google.com Received: from mail-qt0-f177.google.com (HELO mail-qt0-f177.google.com) (209.85.216.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Feb 2018 08:27:29 +0000 Received: by mail-qt0-f177.google.com with SMTP id c7so953052qtn.3 for ; Wed, 21 Feb 2018 00:27:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rRA5zA9ho4tdJf+M4rrG2+I4kja8WyT+/egwk5+vgpc=; b=pw7WkA55b8K0T1oPb+avzuVzT2SCVaCA4tfbn1OYuHZNpP9OX9Izdlc5f34ZoCxp1h zFknglhG0E8GoE02c/n3k6ye6Un40JKgNVxJe51TdYwa9qoGTFeB4dF7zspRvFWbhhIE jl4TnQNkG9EPTK3qlZGnr4ys24lZWkpfZqQcpkacGRjGAUalnqlomAD86hhcGeQwSuHn hkXyHLCp5a4fGUh5D9cnvsvqSUDn5ArjvQmdQFPNRpfGIyXPnIBfc2g0ucZ8K4VBVHrj zvUCXGWNFgJCOPD/oIwKPEgeqVZc9+xnSMTT+Y1Gc8S0XGAoVUF4VC/TvICaO/iq+oWa l+hg== X-Gm-Message-State: APf1xPDuvMurmGE9qsVnfhHa93d8olJS8+SAr2QS/NxQEihp9bdtLq1o P7VP4DmW/jwQmITPB6JlxgXMQaphCq80RFU4fDw= X-Google-Smtp-Source: AH8x226zB42lvKOSKE5MTwQGPbsc+ZV6aT+r5g/zC/3MK2gnOuR2sA1mBxBZ4cNe85w/ljDk83KeKUvqb77JpIa9/9U= X-Received: by 10.237.41.35 with SMTP id s32mr3818407qtd.200.1519201648001; Wed, 21 Feb 2018 00:27:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.168.200 with HTTP; Wed, 21 Feb 2018 00:27:27 -0800 (PST) In-Reply-To: <9c0e590fd8e1d5d54a426aefe7c78650@polymtl.ca> References: <1517999572-14987-1-git-send-email-yao.qi@linaro.org> <1517999572-14987-10-git-send-email-yao.qi@linaro.org> <9c0e590fd8e1d5d54a426aefe7c78650@polymtl.ca> From: Yao Qi Date: Wed, 21 Feb 2018 08:27:00 -0000 Message-ID: Subject: Re: [PATCH 09/10] Move register_dump to regcache-dump.c To: Simon Marchi Cc: GDB Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00286.txt.bz2 On Sat, Feb 17, 2018 at 3:50 AM, Simon Marchi wro= te: > I think it would make sense to move the remaining dump-related things (the > register_dump class, the register_dump::dump implementation) to > regcache-dump.c. > register_dump::dump accesses 'struct regcache_desc', which is declared in regcache.c, so that register_dump::dump can't be moved to regcache-dump.c. --=20 Yao (=E9=BD=90=E5=B0=A7)