From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9345 invoked by alias); 28 Oct 2016 14:18:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9333 invoked by uid 89); 28 Oct 2016 14:18:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-qk0-f181.google.com Received: from mail-qk0-f181.google.com (HELO mail-qk0-f181.google.com) (209.85.220.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Oct 2016 14:18:35 +0000 Received: by mail-qk0-f181.google.com with SMTP id v138so33009665qka.0 for ; Fri, 28 Oct 2016 07:18:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=6i6koZos4/2I3dy65gJTwxflQSF1OZo4LswmF4U1Ih4=; b=Rod3U4FkRdxHfgu0xapRumVGYsq+AR0vNrBcxd6VBHp4Xaby7O2m50JafoNo18/xLw JzfZyXYfqSXqCT0fP12WEOvxVIqUYSp61j1XKFySDZHAkSkax3LlIrks9MSb80HGskuF jVLIH7kRK1d04Z4a8SLyf6VQXo8Xyby6LhhgvbDoONPFxIcIylgKy+HKm1Heofd4F/JM BbwBXlmHQvdqKaflIBwz428w1asqMwURbScBP2xwlXs+jeJJoAnUqT05gsixpPyEWlrd EdQeayf3u76vb+SQwvQVHLimt1e/sihGw8Lbq0osihghkWHHufHo8CbQHIxYIv5udK3E 1jSw== X-Gm-Message-State: ABUngvcuaZNJryXYkyKFJmjsZhD9LQpN7t0EA1vtgrGCHirIo2VqcE7wDEE6S6d7vCEE/m24M3ex5w4U8qf8bw== X-Received: by 10.55.101.151 with SMTP id z145mr10412293qkb.35.1477664313721; Fri, 28 Oct 2016 07:18:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.149.168 with HTTP; Fri, 28 Oct 2016 07:18:33 -0700 (PDT) From: Yao Qi Date: Fri, 28 Oct 2016 14:18:00 -0000 Message-ID: Subject: set_value_component_location in apply_val_pretty_printer To: "gdb-patches@sourceware.org" Cc: Tom Tromey Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00805.txt.bz2 Hi, I don't understand this piece of code in apply_val_pretty_printer, why do we need to call set_value_component_location? set_value_component_location (value, val); /* set_value_component_location resets the address, so we may need to set it again. */ if (VALUE_LVAL (value) !=3D lval_internalvar && VALUE_LVAL (value) !=3D lval_internalvar_component && VALUE_LVAL (value) !=3D lval_computed) set_value_address (value, address + embedded_offset); It was added by Tom in https://sourceware.org/ml/gdb-patches/2010-06/msg00132.html There wasn't much information in email and ChangeLog. --=20 Yao (=E9=BD=90=E5=B0=A7)