From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7592 invoked by alias); 25 Jan 2018 14:03:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7582 invoked by uid 89); 25 Jan 2018 14:03:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=22531, management X-HELO: mail-qt0-f194.google.com Received: from mail-qt0-f194.google.com (HELO mail-qt0-f194.google.com) (209.85.216.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 14:03:12 +0000 Received: by mail-qt0-f194.google.com with SMTP id f4so19369398qtj.6 for ; Thu, 25 Jan 2018 06:03:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Q0EYqYVk/c9OzugX9jA4FtNFTPEVORWiAX9qh3SQqfU=; b=J7UnVFtfpibbA4FR5f2cRPXiENlzleGTKe+JVFYJcvHmQJwqOuEjjTjCiewNidQl9w h/LBy7F/2vb6mvFYvrQd9oBwgP+H35DHAAZWWwFVIOgFP2w/6scVh/2pvLvssQEWCoNI X+4sPZmOxLjrOuT9PlHg+WAiDSqxApnzZ5ro+pkTi8I7u+7GAL47qaPvRy53r6/PIGgT D8QBlpZsQ+h7cTxTLFASMnXGHHgCkugsVugFgrmhdr7ZgeF9+uilfNXWAfiA5B4zpc2l jy0LX678andTr6emKD3U1ie/5Z9Sm2iJCzRie7GDeXjvRm9es0RgDEg/g/lbz6jhF0r5 Gdgw== X-Gm-Message-State: AKwxyteJTW3b7V/gUJyrh5a6o2+TwnCoGFPfRT+zNy8K4zhfMrA4EZd9 NEaa25P8P2iARUXvk/h6hWs/Us2jPo/DxZAzNMU= X-Google-Smtp-Source: AH8x22626Qx6ERROrH3hx/qz7MaBG9e13cFsNaLLFotqJIP9flYRKCFxceJ5G3lLzYo8eAQDeweSk+tFG6h2kbYvi7E= X-Received: by 10.200.57.74 with SMTP id t10mr17880788qtb.22.1516888990301; Thu, 25 Jan 2018 06:03:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.153.232 with HTTP; Thu, 25 Jan 2018 06:03:09 -0800 (PST) In-Reply-To: <20180125120524.4q5zyi5jbpotof6n@adacore.com> References: <1516873114-7449-1-git-send-email-yao.qi@linaro.org> <20180125120524.4q5zyi5jbpotof6n@adacore.com> From: Yao Qi Date: Thu, 25 Jan 2018 14:03:00 -0000 Message-ID: Subject: Re: [PATCH 0/7] Class-fy partial_die_info To: Joel Brobecker Cc: GDB Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00525.txt.bz2 On Thu, Jan 25, 2018 at 12:05 PM, Joel Brobecker wr= ote: > > What's the advantage of turning this struct into a class? > Is it memory management? > > (sorry if it's obvious from the code - C++ dummy, here) > I am fixing PR 22531, that is GDB should coalesce consecutive line table entries in some cases. However, one exception here is that GCC emits two entries to mark the end of prologue. In this case, GDB can't coalesce them. I wrote some unit tests to dwarf_decode_lines_1, with an input to provide dwarf line table, and verify dwarf_decode_lines_1 can get line table correctly. In order to write unit tests, I want to easi= ly create the context for each unit test, like dwarf2_per_cu_data, dwarf2_cu, line_header, etc. So I have to class-fy them, and class-fy these structs requires class-fy other structs, it turns out that I nearly class-fy all st= ructs in dwarf2read.c. This patch series is just part of the whole work. --=20 Yao (=E9=BD=90=E5=B0=A7)