From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC] PR 20939: Handle error in disassembly
Date: Wed, 14 Dec 2016 22:05:00 -0000 [thread overview]
Message-ID: <CAH=s-PNgxkqvU94Qe8fAf-+a=bmE-UNMOC-=pWvYQ1HRbT4P=w@mail.gmail.com> (raw)
In-Reply-To: <f2ee7ac0-8f9f-40fd-0609-acf10874e086@redhat.com>
On 16-12-14 17:31:18, Pedro Alves wrote:
>
> Did you try to find the discussions around when the current
> interface based on throwing (using longjmp at the time) was added?
> Maybe the "return -1" option was considered back then, but
> discarded for some reason?
Such interface was added in 1993,
5d0734a7d74cf01b73303aeb884b719b4b220035 there wasn't any
discussions.
>
> E.g., looks like simply "return -1" would lose the actual
> address that failed to be read, in case opcodes does several
> reads in sequence and its not the first that fails. We could
> add some other means to get at that, of course.
>
I thought about this beofre. We can't get the actual address that
failed to be read today, because we read a piece of memory in
dis_asm_read_memory, but only report error from the starting
address. So I think it isn't very important to report the error with
the accurate memory address failed to be read.
--
Yao
next prev parent reply other threads:[~2016-12-14 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 10:48 Yao Qi
2016-12-14 17:31 ` Pedro Alves
2016-12-14 22:05 ` Yao Qi [this message]
2016-12-16 16:40 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PNgxkqvU94Qe8fAf-+a=bmE-UNMOC-=pWvYQ1HRbT4P=w@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox