From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115132 invoked by alias); 21 Feb 2018 13:59:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115116 invoked by uid 89); 21 Feb 2018 13:59:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f178.google.com Received: from mail-qt0-f178.google.com (HELO mail-qt0-f178.google.com) (209.85.216.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Feb 2018 13:59:01 +0000 Received: by mail-qt0-f178.google.com with SMTP id d8so1983800qtm.0 for ; Wed, 21 Feb 2018 05:59:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wzT687PHIetRRWHEKImUhhwzgH/ASUnUoz0FjPr6GHY=; b=G4Vg1TPTL0jP8F6VQcI9t/qgvvRL4stHWlpfrWswR7RHsY/qgE+ndv8QOJcH7Qygpn oy5LWg6JultqoR4m+qrQG66YFGazserrnIsYmLsR5VXxvhoH+rOvkKgkmBaQoJ44NWwo LWpbf+r7y3ypYEe/zfXIhc1a4aTjbf3qxpDI3a9YNYS0OlVs2/CuD75vNU5kUglZ5OFv qoZzHAg6dzZi9Yo56rXXjc8hLjzHvPiR0rCf59VCWCRQ7Zq4KELjPbNbQ55UWeN1ZdEd 3Vx9RrzkTY4cdMOEvGgMiqLkNmO8mS8ybwaMgv5i1QipdOvJi+xwx1GKp8hhRybme0Q0 2iVQ== X-Gm-Message-State: APf1xPCleskmYffPHwvTgP1LIToyiPMyn1cFCHhAN0865htXPX5rLYcP A3o/RsF8zyemnYMgffqYkobuGtTNKtSZE+bdlO0= X-Google-Smtp-Source: AH8x2272lWPG7xhgAiF5uYomiARSo4WItYBeqjvfbq5eDbgAO5+yw/YLGmEzzwZxyJfvj5LHhAAJmi+5r1g2fjWfC2M= X-Received: by 10.237.36.221 with SMTP id u29mr5162808qtc.116.1519221539599; Wed, 21 Feb 2018 05:58:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.168.200 with HTTP; Wed, 21 Feb 2018 05:58:59 -0800 (PST) In-Reply-To: References: <1517999572-14987-1-git-send-email-yao.qi@linaro.org> <1517999572-14987-10-git-send-email-yao.qi@linaro.org> <9c0e590fd8e1d5d54a426aefe7c78650@polymtl.ca> From: Yao Qi Date: Wed, 21 Feb 2018 13:59:00 -0000 Message-ID: Subject: Re: [PATCH 09/10] Move register_dump to regcache-dump.c To: Simon Marchi Cc: GDB Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00292.txt.bz2 On Wed, Feb 21, 2018 at 12:57 PM, Simon Marchi wr= ote: >> >> register_dump::dump accesses 'struct regcache_desc', which is declared in >> regcache.c, so that register_dump::dump can't be moved to >> regcache-dump.c. > > > Is there any reason we can't move struct regcache_descr to regcache.h? The reason I didn't move is that I want to keep regcache_descr opaque. To be clear, I don't mind moving regcache_descr to regcache.h and move all regcache dump stuff into regcache-dump.{c,h}. --=20 Yao (=E9=BD=90=E5=B0=A7)