From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89339 invoked by alias); 6 Oct 2016 08:44:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89320 invoked by uid 89); 6 Oct 2016 08:44:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1668 X-HELO: mail-oi0-f41.google.com Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 08:44:07 +0000 Received: by mail-oi0-f41.google.com with SMTP id n132so14105880oih.1 for ; Thu, 06 Oct 2016 01:44:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=uMgcEA+jqYT2WzRgV5uxq+fXidu+QPWRGGY6zYlKD+U=; b=E5CE+WA2Nqokh6CMUnQG5e6nV4X4xaP+Qcs9PZ/DNZSVU2d/GWnlYYHUrV5mVNAmHw ZCvx0zwdWmmkxwsLkHbHoC4g+2XQO4p8sOhNQ+J1xF+nBk3lTiXyahNE3eYJ93mras1X 41HLoZxpCyMvC9KgV0yD+n8VRekK0HGi4CdZUlKucMKjeCvk76qfS5cyOWo9KXMeWcu3 4vOiUiP2otOhdBwct6hhn1/4hxtE7efwq9Ggj3ssmgtG6hFvuYO3uJxzYSg+xg/87z28 ydmGzzpHfLErq6+mDdxZf/n1PxTvmcW4aDGZYhH7Z/ay1CWIPtiva+/29yyOiKORoWWn Ke/w== X-Gm-Message-State: AA6/9RkIR3wS2S9UeqU7nhMqvfeSZTIl9HuPp7IQeTZYtxDYh9YWPwhF2XRRPmlMuPnwrtmNxkrCIkU7dDky4Q== X-Received: by 10.202.82.7 with SMTP id g7mr11303929oib.112.1475743446360; Thu, 06 Oct 2016 01:44:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.221.3 with HTTP; Thu, 6 Oct 2016 01:44:05 -0700 (PDT) In-Reply-To: <20161003191729.1412-1-simon.marchi@ericsson.com> References: <20161003191729.1412-1-simon.marchi@ericsson.com> From: Yao Qi Date: Thu, 06 Oct 2016 08:44:00 -0000 Message-ID: Subject: Re: [PATCH] gdb.btrace/*.exp: Make test names unique To: Simon Marchi Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00106.txt.bz2 On Mon, Oct 3, 2016 at 8:17 PM, Simon Marchi Patch is good to me, some nits below, > # we can read memory if we explicitly allow it. > -gdb_test_no_output "set record btrace replay-memory-access read-write" > -gdb_test "print glob" "1" > +with_test_prefix "replaying, replay-memory-access =3D read-write" { > + gdb_test_no_output "set record btrace replay-memory-access read-writ= e" Nit, I'd like to move this test out of with_test_prefix block, as it is uni= que. > + gdb_test "print glob" "1" > +} > > # we can't if we don't explicitly allow it. > -gdb_test_no_output "set record btrace replay-memory-access read-only" > -gdb_test "print glob" "unavailable\[^\\\r\\\n\]*" > +with_test_prefix "replaying, replay-memory-access =3D read-only" { > + gdb_test_no_output "set record btrace replay-memory-access read-only" Likewise. > + gdb_test "print glob" "unavailable\[^\\\r\\\n\]*" > +} > > diff --git a/gdb/testsuite/gdb.btrace/delta.exp b/gdb/testsuite/gdb.btrac= e/delta.exp > index c9dbf38..c822400 100644 > --- a/gdb/testsuite/gdb.btrace/delta.exp > +++ b/gdb/testsuite/gdb.btrace/delta.exp > @@ -47,7 +47,7 @@ with_test_prefix "no trace" { > } > > # we record each single-step, even if we have not seen a branch, yet. > -gdb_test "stepi" > +gdb_test "stepi" "main\.4.*" "stepi #1" > > proc check_trace {} { > gdb_test "info record" [multi_line \ > @@ -70,18 +70,18 @@ with_test_prefix "twice" { > } > > # check that we can reverse-stepi that instruction > -gdb_test "reverse-stepi" > +gdb_test "reverse-stepi" "main\.3.*" This doesn't change the test message in gdb.sum, but good to have it. --=20 Yao (=E9=BD=90=E5=B0=A7)