From: Yao Qi <qiyaoltc@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-buildbot@sergiodj.net, GDB Patches <gdb-patches@sourceware.org>
Subject: Re: Oh dear. I regret to inform you that commit 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f might be unfortunate [gdb-8.1-branch]
Date: Fri, 05 Jan 2018 08:56:00 -0000 [thread overview]
Message-ID: <CAH=s-PNdJ4cKt4MvMm+heZegAr5ZrHwZXFyPmuAij-vMssvWvQ@mail.gmail.com> (raw)
In-Reply-To: <20180105072540.gxbdc5nhwzevlawl@adacore.com>
On Fri, Jan 5, 2018 at 7:25 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> It is a matter of great regret and sadness to inform you that commit:
>>
>> Set development mode to "off" by default.
>> 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f
>>
>> might have made GDB unwell. Since I am just your Butler BuildBot,
>> I kindly ask that a human superior officer double-check this.
>>
>> Please note that if you are reading this message on gdb-patches, there might
>> be other builders broken.
>
> The patch controls the configure variab1e "development". Looking
> at the configure.ac script, I found that the selftest tests
> are only activated when it is set:
>
> if $development; then
> AC_DEFINE(GDB_SELF_TEST, 1,
> [Define if self-testing features should be enabled])
> CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_UNITTESTS_OBS)"
> CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_UNITTESTS_SRCS)"
> fi
>
> I assume the error is related to the above, since it's a link
> failure related to selftests...
>
This is about including self test cases when $development is true. It is not
related to the link failure below...
> | [...]
> | ../readline/libreadline.a ../opcodes/libopcodes.a ../bfd/libbfd.a -L./../zlib -lz ../libiberty/libiberty.a ../libdecnumber/libdecnumber.a -ldl -ldl -lncursesw -lm -ldl -lguile-2.0 -lgc -lpthread -ldl -lutil -lm -lpython2.7 -lexpat -llzma -lbabeltrace -lbabeltrace-ctf -lipt ../libiberty/libiberty.a build-gnulib/import/libgnu.a -ldl -Wl,--dynamic-list=../../binutils-gdb/gdb/proc-service.list
> | selftest.o: In function `selftests::run_tests(char const*)':
> | /home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64/build/gdb/../../binutils-gdb/gdb/common/selftest.c:97: undefined reference to `selftests::reset()'
> | collect2: error: ld returned 1 exit status
selftest.o shouldn't be compiled when $development is false. I think selftest.o
shouldn't be put into COMMON_OBS unconditionally. I'll take a look.
--
Yao (齐尧)
next prev parent reply other threads:[~2018-01-05 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 5:25 gdb-buildbot
2018-01-05 5:25 ` Breakage on builder Fedora-x86_64-m64, revision 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f [gdb-8.1-branch] gdb-buildbot
2018-01-05 5:25 ` Breakage on builder Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2018-01-05 5:29 ` Breakage on builder Fedora-i686, " gdb-buildbot
2018-01-05 5:32 ` Breakage on builder Fedora-x86_64-m32, " gdb-buildbot
2018-01-05 5:35 ` Breakage on builder Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2018-01-05 5:39 ` Breakage on builder Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2018-01-05 5:40 ` Breakage on builder Fedora-x86_64-cc-with-index, " gdb-buildbot
2018-01-05 5:43 ` Breakage on builder Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2018-01-05 5:59 ` Breakage on builder Ubuntu-AArch64-native-gdbserver-m64, " gdb-buildbot
2018-01-05 6:14 ` Breakage on builder Ubuntu-AArch64-m64, " gdb-buildbot
2018-01-05 7:25 ` Oh dear. I regret to inform you that commit 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f might be unfortunate [gdb-8.1-branch] Joel Brobecker
2018-01-05 8:56 ` Yao Qi [this message]
2018-01-05 7:29 ` Breakage on builder Ubuntu-AArch32-native-extended-gdbserver-m32, revision 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f [gdb-8.1-branch] gdb-buildbot
2018-01-05 7:46 ` Breakage on builder Ubuntu-AArch32-native-gdbserver-m32, " gdb-buildbot
2018-01-05 8:03 ` Breakage on builder Ubuntu-AArch32-m32, " gdb-buildbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PNdJ4cKt4MvMm+heZegAr5ZrHwZXFyPmuAij-vMssvWvQ@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-buildbot@sergiodj.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox