From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27933 invoked by alias); 21 Jul 2016 16:35:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27918 invoked by uid 89); 21 Jul 2016 16:35:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=gdbtesters, gdb-testers X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 21 Jul 2016 16:35:45 +0000 Received: by mail-oi0-f44.google.com with SMTP id l65so125437623oib.1 for ; Thu, 21 Jul 2016 09:35:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=T+ASLSPEV66lsUN/QUwXcNKFbkG0COKIvXZihIIHZSc=; b=ao6iTol5e0CDX6ET00323mOMrwGip/NWTImUKGXJqjnUL944om8Tnd9lw7IyUA5zzy H4IOkPRjFI1LJNCD+o3Ni8cyiXl+48DgXnUrmakGvvK/EyxdtpGjIyS79GcYBv32LERB 89kcFl7JsFcf2mH1qVh8G5jfROSkE6rQhR35v16Q+Mul0/+g8vFFQ66xVjr2f3PbIGb+ CrYMLK34bTwWgt54EVB7rYDm4Bb116Eh8YlfM1upc8PFV2jw8UkOMlGQvPO2HFbyVKZg 6/W98Jo8tSjY+xthgCUi4vvy73GoHhu8uu+SDoD20q+kWKUvdMdV9nz8vEbsobNtnSdO A8qA== X-Gm-Message-State: ALyK8tK3V0rbmdxiQeE7qzLh46Fb164Nv5M0s9jeQLa6De9lTBxaP53QeH6jiGtjqpVd20ZNUmX1QwRJgEDdfA== X-Received: by 10.157.12.219 with SMTP id o27mr31181995otd.103.1469118944072; Thu, 21 Jul 2016 09:35:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.105.138 with HTTP; Thu, 21 Jul 2016 09:35:43 -0700 (PDT) In-Reply-To: <1455207283-12660-2-git-send-email-markus.t.metzger@intel.com> References: <1455207283-12660-1-git-send-email-markus.t.metzger@intel.com> <1455207283-12660-2-git-send-email-markus.t.metzger@intel.com> From: Yao Qi Date: Thu, 21 Jul 2016 16:35:00 -0000 Message-ID: Subject: Re: [PATCH v3 2/3] stack: check frame_unwind_caller_id To: Markus Metzger Cc: Pedro Alves , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00264.txt.bz2 Hi Markus, On Thu, Feb 11, 2016 at 4:14 PM, Markus Metzger wrote: > diff --git a/gdb/stack.c b/gdb/stack.c > index 89879f3..6e3acc7 100644 > --- a/gdb/stack.c > +++ b/gdb/stack.c > @@ -1509,27 +1509,32 @@ frame_info (char *addr_exp, int from_tty) > wrap_here (" "); > printf_filtered ("saved %s =3D ", pc_regname); > > - TRY > - { > - caller_pc =3D frame_unwind_caller_pc (fi); > - caller_pc_p =3D 1; > - } > - CATCH (ex, RETURN_MASK_ERROR) > + if (!frame_id_p (frame_unwind_caller_id (fi))) > + val_print_unavailable (gdb_stdout); > + else This patch causes a fail FAIL: gdb.dwarf2/dw2-undefined-ret-addr.exp: info frame because part of the output "info frame" is changed from "saved rip =3D " to "saved rip =3D ". The regression is caught by buildbot too https://sourceware.org/ml/gdb-testers/2016-q1/msg05292.html Could you take a look? Note that Jan posted a patch https://sourceware.org/ml/gdb-patches/2016-04/msg00181.html fixing test case, but I think the test case itself is valid. Also in the c= ommit log of adding gdb.dwarf2/dw2-undefined-ret-addr.exp, it is intended to match "" in the test. --=20 Yao (=E9=BD=90=E5=B0=A7)