From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3282 invoked by alias); 30 Oct 2017 09:35:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3262 invoked by uid 89); 30 Oct 2017 09:35:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=lean X-HELO: mail-qk0-f174.google.com Received: from mail-qk0-f174.google.com (HELO mail-qk0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Oct 2017 09:35:14 +0000 Received: by mail-qk0-f174.google.com with SMTP id b15so15257662qkg.9 for ; Mon, 30 Oct 2017 02:35:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PicypwWZvR48+R4BmrLyCMT9Loo+vEZO+uLZsU+Lhkk=; b=fDJxKghl3dw3avIb5Iv+6hbkDLF6lgcxIx1Xoj1EsXxDuX/nkeP5Lkb35phmO5BiYI FE4OBzCCyb2q8OR7hIBWDFiJE5QmyFY9Ta/b3OHWpAbD30Yq1m9EfnQYH+dyqxlBdv7T nUIHz/0UOFFdzse4Wv49+/UWFNlJcH5+illQfhkLo8ytgJQYXpFjvnvajUJDyxO3fa+Q Gq1fgakGSVYJfgc9oBNe4jVAh5gruFkVp2TfBUz+U7i3p2VTiQ+zuLgUTaK1YUt4JVf+ DQ+7zir9ImBza/IQ4it9jOeckVY+HoAaejziJctpcT58Wt4nZck2pim1HMQ+uvOhXecz J+PA== X-Gm-Message-State: AMCzsaX9Syo82RRkvMjYr0akA0XcRegW85d6p7niu9FKGRl0PMqtK4fS 1HcQLat3qsMeFuBiDkPvZjJASStGOkejvhBSDGU= X-Google-Smtp-Source: ABhQp+Q6F7PVSaeVfiJe+cQsHRLunIwUwRMWqQmFZhTqx2TaQ6nefyD6rGAHltvei9z5+8W+hTFHMJyrffq86v0+5Jk= X-Received: by 10.55.186.71 with SMTP id k68mr12600019qkf.100.1509356112852; Mon, 30 Oct 2017 02:35:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.153.208 with HTTP; Mon, 30 Oct 2017 02:35:12 -0700 (PDT) In-Reply-To: References: From: Yao Qi Date: Mon, 30 Oct 2017 09:35:00 -0000 Message-ID: Subject: Re: Opinion about -Wtautological-compare To: Simon Marchi Cc: GDB Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00877.txt.bz2 On Sat, Oct 28, 2017 at 4:24 AM, Simon Marchi w= rote: > Personally, I think the warning is useful and can reveal bugs, so I'd lik= e to keep > it. I lean towards 2 or 3, because they help convey the idea that we che= ck if the > value is within a range. If you are following with the architecture manu= al on the > side, it will probably show the same range (0-3) for those bits, so it he= lps if the > code does the same. > My vote is 3. PR 22188. --=20 Yao (=E9=BD=90=E5=B0=A7)