From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91440 invoked by alias); 21 Jul 2016 11:18:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91431 invoked by uid 89); 21 Jul 2016 11:18:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=chat, Hx-languages-length:1643, ideal X-HELO: mail-oi0-f67.google.com Received: from mail-oi0-f67.google.com (HELO mail-oi0-f67.google.com) (209.85.218.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 21 Jul 2016 11:18:12 +0000 Received: by mail-oi0-f67.google.com with SMTP id c199so7403512oig.1 for ; Thu, 21 Jul 2016 04:18:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=OYqgL/Q3jtDejJNIAwg86nOGScCyjlBUdLCdmkbie9s=; b=KokE2lpxOEaAK3c2DEbCUBOzQ67GgH7QVZgC1TZBfCh/KCoaqPG+ML5G50M5KzUP+j RjTbYKbhQ6NtKxJQUy2KzEqslaT7PiItdJ51oegsVGE9G/WVQNDfhufq5d/Jn3snEiql YylUyQbLLn06GUvp2vwyUo9DxOutuXzATCyz9JGwLVGSnB9qkC8pe6MacuWYkinmfGce NQGzHga1/+C+AurKaSxm0rFpOAsHfRhnts1zyfodcSsEHaMwTHuMBjp13vgWwuaU0cHd FMUkXjmIBS/fK1k3Rti+/3BXaB8aDTt41jIBZjGJpbHym6PrfwuuMTYCOFxFTULsBaGS 2Nug== X-Gm-Message-State: ALyK8tJkKTMlaweJXPDJXuDJeIVDVsGhmHtpKG6Ey/bKp7WY+ONQHGrU0oS43G+HnXJPwYUmP06h2bfLbL16Ng== X-Received: by 10.202.213.135 with SMTP id m129mr24401545oig.89.1469099890156; Thu, 21 Jul 2016 04:18:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.105.138 with HTTP; Thu, 21 Jul 2016 04:18:09 -0700 (PDT) In-Reply-To: <1467295765-3457-1-git-send-email-yao.qi@linaro.org> References: <1467295765-3457-1-git-send-email-yao.qi@linaro.org> From: Yao Qi Date: Thu, 21 Jul 2016 11:18:00 -0000 Message-ID: Subject: Re: [PATCH 0/9 V3] Use reinsert breakpoint for vCont;s To: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00243.txt.bz2 On Thu, Jun 30, 2016 at 3:09 PM, Yao Qi wrote: > Here is the V3 of this patch series, V2 can be found > https://sourceware.org/ml/gdb-patches/2016-06/msg00029.html > some preparatory patches in V2 are already pushed in. Patches > 1 - 5 and 9 are already approved in V2 review. > > This patch series is to address the review comments > https://sourceware.org/ml/gdb-patches/2016-06/msg00305.html > >> Hmm, seeing that we need to handle installing the breakpoints in >> both places, I wonder about making linux_resume just handle >> setting up the last resume kind and queue signals, and then >> end up calling proceed_all_lwps. If that works, I suspect it >> would simplify things a good deal. > > I do something slightly differently in V3. In my > "V2 Use reinsert breakpoint for vCont;s", I install reinsert breakpoints > for needed lwps in two places, linux_resume and proceed_all_lwps, which > isn't ideal. > > After the chat with Pedro, we don't need to stop all threads when inserti= ng > reinsert breakpoint, so we can move the breakpoint installation further > down to linux_resume_one_thread and proceed_one_lwp. If > linux_resume_one_thread can use proceed_one_lwp, we can only install > reinsert breakpoints in one place, proceed_one_lwp. Patch 7 changes > linux_resume_one_thread enqueues signal and calls proceed_one_lwp. > Patch 6 is a refactor one to use existing api enqueue_pending_signal. > With the changes in patch 7, patch 8 is simplified compared with V2. > > Regression tested on arm-linux and x86_64-linux. > I pushed them in. --=20 Yao (=E9=BD=90=E5=B0=A7)