From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45229 invoked by alias); 12 Jan 2017 21:09:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45216 invoked by uid 89); 12 Jan 2017 21:09:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:a6bdf8e, H*i:sk:a6bdf8e, =e5=b0=a7?= X-HELO: mail-qk0-f196.google.com Received: from mail-qk0-f196.google.com (HELO mail-qk0-f196.google.com) (209.85.220.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jan 2017 21:09:05 +0000 Received: by mail-qk0-f196.google.com with SMTP id u25so4454277qki.2 for ; Thu, 12 Jan 2017 13:09:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IeuSgXdq8TK0N0UibKQoTMtz2cBAmw6gYLceQc3O+rQ=; b=ubxqkKyq0Yi4Vb6TEz68BRhtq4DqmXdORW2ILbpgIAhovdEqfJbGsD/JTZeoTA2ilo YsLpGUr8mNo4icz9PV7CxjyC4pDCw+n2xxik/Kog8wabdsXz/xzr050fn0WQaaM/U1+b ANzYPVPtRn5PXoPLKOjJLTOtT6Kaw16YmHHovxayPG4W51CpnUaqMOf2uFtkjNsT60b0 PpDr3bsI52Fgr/RETEt1jg7+6mNYnyR0/MLtowopxQQOdofAc9IOKRl8kW0E4v5j/+wB K0AkrOT4Rq/1nY9ZLCkuKMX3DxXyyS9gWeoPnbnlA7ngGYFk/yKhn3mwhMx0oGpH+m8v 9lIA== X-Gm-Message-State: AIkVDXLcIuMV1MOmG8dkpr3IeElceG0CvY6S/dhANqDPkLoSdNsDApfsvvOSpl9RkVeZS6rcZZFMKEZd4iyLFg== X-Received: by 10.55.161.212 with SMTP id k203mr16860689qke.234.1484255343478; Thu, 12 Jan 2017 13:09:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.144.11 with HTTP; Thu, 12 Jan 2017 13:09:03 -0800 (PST) In-Reply-To: References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-9-git-send-email-yao.qi@linaro.org> From: Yao Qi Date: Thu, 12 Jan 2017 21:09:00 -0000 Message-ID: Subject: Re: [PATCH 8/8] Don't throw exception in dis_asm_memory_error To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00253.txt.bz2 On Thu, Jan 12, 2017 at 4:40 PM, Pedro Alves wrote: > On 01/10/2017 12:26 PM, Yao Qi wrote: >> --- a/gdb/testsuite/gdb.base/all-architectures.exp.in >> +++ b/gdb/testsuite/gdb.base/all-architectures.exp.in >> @@ -152,6 +152,9 @@ proc print_floats {} { >> >> proc do_arch_tests {} { >> print_floats >> + >> + gdb_test_internal "disassemble 0x0,+4" \ >> + "Cannot access memory at address 0x0" >> } > > This will fail if you're testing against a non-MMU target, > where you can read address 0. Check is_address_zero_readable? > There is no live inferior created in the test, so GDB can't access any memory. Probably I need a line of comment, # GDB can't access any memory because there is no live inferior. --=20 Yao (=E9=BD=90=E5=B0=A7)