From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79925 invoked by alias); 28 Jun 2016 14:36:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79832 invoked by uid 89); 28 Jun 2016 14:36:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Fish X-HELO: mail-oi0-f52.google.com Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 28 Jun 2016 14:36:14 +0000 Received: by mail-oi0-f52.google.com with SMTP id f189so25258646oig.3 for ; Tue, 28 Jun 2016 07:36:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=U1emGnqSWKp3T+/oea8NU9I+LYdZ32u1B11d6D2ba88=; b=HE7cHtzd9jAbHJIXuzWG7Gn2byff4ct1JHMQMwj2Gdnwg0uBn/spvUmp63T5f5P4hv /dufZ7ZYPlWrpldOhdb7ENCYfD34LML63+1pZEa1jBw4jtu0oeYRfbYcNgd1A8f0N12p HcdMAHnP3Whco8ELUF4AJ5RXlrfJkTuLb35El7fLd+TmNHiMWHD/N0MHv9L57HS2J/jz DQ0Fs5tD8i6f+urSi2oTv4r5mi+bc8tdMvBX5kRE553jgb3247PhGteegHuwuKvafxeY ijm3C195icYBMbEueVgcGoW4Zd818+hiLgDffRay4gy3kK7cMynnvxcJGYxgbfxnGDJ/ yy9Q== X-Gm-Message-State: ALyK8tJdGX/hfWTtic2rQtzM3ak7ye+RuhHqfW2+3Du2BqNY7sYhkmPS3zvOLh1UJoAC83FmiA3Qg33k25jsiA== X-Received: by 10.157.11.230 with SMTP id 93mr2064224oth.103.1467124572854; Tue, 28 Jun 2016 07:36:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.182.130 with HTTP; Tue, 28 Jun 2016 07:36:12 -0700 (PDT) In-Reply-To: <1465248812-23902-4-git-send-email-tom@tromey.com> References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-4-git-send-email-tom@tromey.com> From: Yao Qi Date: Tue, 28 Jun 2016 14:36:00 -0000 Message-ID: Subject: Re: [RFA 3/6] Comment out some unused overlay code To: Tom Tromey Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00463.txt.bz2 On Mon, Jun 6, 2016 at 10:33 PM, Tom Tromey wrote: > This patch comments out some unneeded initializations in overlay code > in symfile.c. Normally I would not comment out code like this, but > the uses of "size" in these functions are commented out. If you'd > prefer I could just delete the comments. I am inclined to remove these commented-out statements. These statements were commented out in 1998, and nobody wanted to add them back again since then, Fri Jan 23 07:47:06 1998 Fred Fish * config/d10v/tm-d10v.h (CALL_DUMMY): Define as "{ 0 }". (TARGET_READ_FP): Define to d10v_read_fp rather than d10v_read_sp. (TARGET_WRITE_FP): Define to d10v_write_fp rather than d10v_write_s= p. (d10v_write_fp, d10v_read_fp): Add prototypes. * symtab.c (decode_line_1): Remove assignment of sals[0].pc field. * symfile.c (simple_overlay_update, simple_overlay_update_1): Ignore the size of overlay sections. This check is redundant anywa= y. --=20 Yao (=E9=BD=90=E5=B0=A7)