From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64749 invoked by alias); 15 Jun 2016 08:44:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64729 invoked by uid 89); 15 Jun 2016 08:44:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:sh-tdep.c, shtdepc, Alternatively, sh-tdep.c X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-oi0-f41.google.com Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 15 Jun 2016 08:44:57 +0000 Received: by mail-oi0-f41.google.com with SMTP id w5so23431643oib.2; Wed, 15 Jun 2016 01:44:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=G2HQCQTLVo7pAYjT6s4GDzHgTq2dmnQ05l1GykMZM7k=; b=TWbW9FVKmqImlPx/CoTTrtMsSEpKveMhcADs7OwU11hJYfX2M3D1Rn/uYzlnxAezBl GSqRhlsUjF/htzAR3cC0MvcMLc9O+rVFXmpXbetPNySEx+Ea0GZYfpPIWtj1LKgr75qZ zSUjYVD5O9mzA1rIKULzyQHQNUygHij3tvVbZ0P1BwZ5VEmSZ/pvkQEwVG77QQRSmbkx wJHOzRKd9ogBYRWzBiiA5jB1Z44R/SDC0SYmr9vv9eCl2BIDyg6EScV/ouGtwQ4zcrXZ Pz3bKrDZTw8IEs+CBlw7OaupsvMcIFHPmQG42/oDkegr+gtCDqB9nguzpcXI5CxMUTDW COMQ== X-Gm-Message-State: ALyK8tJU0J7fd2i48rCAE/a/nSS/vn9wYil8sUqSzyEryF7ATrGed4DqclXJ/SsHC8GdOyy3fjYX8s0gO3hKzQ== X-Received: by 10.202.205.87 with SMTP id d84mr12926222oig.131.1465980295817; Wed, 15 Jun 2016 01:44:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.68.4 with HTTP; Wed, 15 Jun 2016 01:44:55 -0700 (PDT) In-Reply-To: <2059915.yo7jaW82vP@ralph.baldwin.cx> References: <1465678115-58170-1-git-send-email-jhb@FreeBSD.org> <1465678115-58170-6-git-send-email-jhb@FreeBSD.org> <2059915.yo7jaW82vP@ralph.baldwin.cx> From: Yao Qi Date: Wed, 15 Jun 2016 08:44:00 -0000 Message-ID: Subject: Re: [PATCH 5/8] Detect a frameless frame by comparing the FP register to -1. To: John Baldwin Cc: "gdb-patches@sourceware.org" , binutils@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00263.txt.bz2 On Tue, Jun 14, 2016 at 7:46 PM, John Baldwin wrote: > On Monday, June 13, 2016 12:22:41 PM Yao Qi wrote: >> On Sat, Jun 11, 2016 at 9:48 PM, John Baldwin wrote: >> > >> > - if (cache->saved_regs[MEDIA_FP_REGNUM] >=3D 0) >> > + if (cache->saved_regs[MEDIA_FP_REGNUM] =3D=3D -1) >> > cache->uses_fp =3D 1; >> >> I suspect it should be " !=3D -1". saved_regs[MEDIA_FP_REGNUM] is initi= alized >> to -1, so if it is not the initialized value (-1), FP should be set in >> the prologue, and mark the flag uses_fp. > > Yes, you are correct. Alternatively, we could change this code to explic= itly > set 'cache->uses_fp' in the cases earlier in this function where it sets > MEDIA_FP_REGNUM to a value. sh-tdep.c follows this model, but it only ne= eds > to set uses_fp in a few places. > That is fine by me. --=20 Yao (=E9=BD=90=E5=B0=A7)