Re: [PATCH 1/2] Fix lwp_suspend/unsuspend imbalance in linux_wait_1

Antoine Tremblay
2016-08-31T19:16:53Z

Antoine Tremblay writes:

> Pedro Alves writes:
>
>> On 08/31/2016 06:50 PM, Antoine Tremblay wrote:
>>>
>>> Pedro Alves writes:
>>>
>>>> On 08/31/2016 06:14 PM, Antoine Tremblay wrote:
>>>>> This patch fixes imbalanced lwp_suspend/unsuspend calls caused by the
>>>>> premature choosing of another event for fairness.
>>>>>
>>>>> select_event_lwp would switch the event before a call to
>>>>> unsuspend_all_lwps, thus it would be called with the wrong event.
>>>>
>>>> Hmm, that does sound wrong.
>>>>
>>>> Patch LGTM.
>>>>
>>>
>>> Thanks, pushed.
>>
>> Could you push it to 7.12 as well?
>>
>
> OK, pushed to 7.12
>
>> I wonder whether this might fix:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=20176
>>
>
> I hope they will retest.

BTW I always wanted to do this but never get to it, but it seems to me
that it would be nice to have a --fatal-asserts flags in GDB that would
create a core on assert.

That way we could get a backtrace of the assert and know if we fixed a
particular issue like this case.

Regards,
Antoine