From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13751 invoked by alias); 20 Jul 2016 11:20:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13733 invoked by uid 89); 20 Jul 2016 11:20:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f49.google.com Received: from mail-oi0-f49.google.com (HELO mail-oi0-f49.google.com) (209.85.218.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 20 Jul 2016 11:20:31 +0000 Received: by mail-oi0-f49.google.com with SMTP id j185so66545477oih.0 for ; Wed, 20 Jul 2016 04:20:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hatD4mK7uh0WV/M6W677OSibXx6wkgdE3EFXAvr1bIo=; b=afoQPEMXnZmIZhSCNWc4mqj6yqa8MKtZxUruP/s0xPQYPrNuK9/93M5/5v5Y90whE2 Ppbw2KPV1g+IVf5yfb9heRFHIt9lDolzfTvWZ0dNk916Dx6Rp1jFEMtgdGek3oGafYUc cXyiLvC9GznwbNdCLWkF9UYlyDF6irEd5YybAzwq8JfWZjXsdW7UI3XA6Ka0R+leVPcj z3lnuNIVZoq0EhLynbNT2zn0eXujc9wJgm1MXb00SmXBylcKrwEKaQC7SQuT6Sz7ftWO Lc933ArZG2KEE0Q9FH6reDHh7iTkPT7LC2pC8OlWjegwNirbXSwSf1V8wLGG1nUzsMJ3 Hb3A== X-Gm-Message-State: ALyK8tKGqvpW8zqnyAgAUXEUE6TFndE+BIeK4pDD4jof9DlIV2eGZuPlKd60p617N6jZHEjS5c+/q8emG1o1+Q== X-Received: by 10.157.11.163 with SMTP id 32mr26635598oth.119.1469013629026; Wed, 20 Jul 2016 04:20:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.105.138 with HTTP; Wed, 20 Jul 2016 04:20:28 -0700 (PDT) In-Reply-To: References: <20160717143003.GA12147@host1.jankratochvil.net> <20160718113348.GA25789@host1.jankratochvil.net> From: Yao Qi Date: Wed, 20 Jul 2016 11:20:00 -0000 Message-ID: Subject: Re: [testsuite patch] Skip py-unwind.exp on x86_64 -m32 To: Pedro Alves Cc: Jan Kratochvil , "gdb-patches@sourceware.org" , Sergio Durigan Junior Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00212.txt.bz2 On Tue, Jul 19, 2016 at 7:04 PM, Pedro Alves wrote: > On 07/19/2016 11:06 AM, Yao Qi wrote: > >> IMO, it is wrong that py-unwind.py creates an x86_64 specific unwinder. > > I find the "wrong" qualifier a bit too strong, since it is probably > not possible to make this sort of test completely arch-independent. > At least py-unwinder.py should create unwinder for each arch, or we should rename it to py-unwinder-$arch.py, as you said. >> py-unwind.py should create a unwinder instance according to the arch if = the >> arch is supported. On i386, or other archs, like arm, mips, py-unwind.py >> can error, and py-unwind.exp knows unwinder is not created successfully, >> and mark the test unsupported. If people want to extend py-unwind.py for >> their archs, they can modify py-unwind.py to create an unwinder instance >> for their own arch. >> >>> The problem here is that py-unwind.exp thinks that it runs on arch x86_= 64 but >>> it runs on arch i386. >>> >>> Even if py-unwind.exp did support i386 it would still FAIL because it w= ould >>> run the testcase for %rbp/%rsp/%rip. >> >> py-unwind.exp does nothing on arch specific thing, so py-unwind.exp shou= ldn't >> be aware of the arch difference, but py-unwind.py should. >> > > Looks like py-unwind.c is ABI-specific as well, and that there's not much= code > that can be shared between architectures in py-unwind.py, though. It may= be we'd > end up with separate py-unwind-$arch.py|c files even. Agreed. > > How about we handle this in the .exp file for now and leave something > more complicated for when the test is first ported to some other > arch. WDYT? > Well, that is fine by me, because I don't plan to port this test to arm or aarch64 recently. --=20 Yao (=E9=BD=90=E5=B0=A7)