From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20645 invoked by alias); 6 Feb 2018 21:24:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20434 invoked by uid 89); 6 Feb 2018 21:24:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=belonging X-HELO: mail-qt0-f181.google.com Received: from mail-qt0-f181.google.com (HELO mail-qt0-f181.google.com) (209.85.216.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Feb 2018 21:24:37 +0000 Received: by mail-qt0-f181.google.com with SMTP id z10so4254147qti.5 for ; Tue, 06 Feb 2018 13:24:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mgbQtgHw/duUC1y0B6cf7ULMHqJBtbHAe/HiTYd2Jps=; b=GPXaPfAs1ad67YbzNVgAlAYnLewr2UuqCE0VozVgnWFY4JVEYLdUICZ7ql3utycFAm uUlhTtrhVkXXMzKOS6MiZfDffsM5lsQfkGvPwyyGf0RrE2oemW/nitRKj8cil/xNko8s 1DfQOgWbHLu+ZAdUIk3cO7j2AZ1e9e4YycGahEWvzaaKxkXc1pGsplr8/8IqwaqK9jvk mNEUsZh/+WAN4nE5/un7XCSUbFT5eRFiAhoS/bZnSkWYcbgkNpSiFaGawvGlXeJqwAJu lVNjg72Zy8E956jKoxnEEOSyzQU/tXuNxMCoS9kaP15s/0d53CUnPjmvS/+rs5j8hMbe cL/A== X-Gm-Message-State: APf1xPAMBl1H+0JjPMkKHd+3CMC85y7l7vU8VRFfjF1G6EZtqjVWeBGR e5Vh8+FK1HbcBld9KxTHIvAS5m+4MKGQszpDvHA= X-Google-Smtp-Source: AH8x225bpvIJfT20HAfVk9oL/0duZvlMuCMXDbkSqV8HLR0otZJp2wTy1Bz1gFtQyJJv0ZP0utMhEaKIO+xSu24SQxQ= X-Received: by 10.237.38.101 with SMTP id z92mr5392342qtc.62.1517952276196; Tue, 06 Feb 2018 13:24:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.153.232 with HTTP; Tue, 6 Feb 2018 13:24:35 -0800 (PST) In-Reply-To: <20180206185609.3219ef39@ThinkPad> References: <97948063-b3db-fd3a-f62e-b552935cb8dd@arm.com> <20180201121443.43322674@ThinkPad> <59984094-96C1-4D84-89F6-384769471005@arm.com> <86k1vqjd5s.fsf@gmail.com> <20180206185609.3219ef39@ThinkPad> From: Yao Qi Date: Tue, 06 Feb 2018 21:24:00 -0000 Message-ID: Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h To: Philipp Rudo Cc: Alan Hayward , "gdb-patches@sourceware.org" , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00098.txt.bz2 On Tue, Feb 6, 2018 at 5:56 PM, Philipp Rudo wro= te: > Of course you could name the *.h file anything you want. But from my poi= nt of > view the *.c and *.h files belonging together should have the same name. > Having this in mind you cannot call it common/tdesc.h because in > gdbserver/Makefile:OBS the directory is ignored and both (common/tdesc.c = and > gdbserver/tdec.c) would be compiled to tdesc.o, (most likely) leading to > unintended behavior. What I want is to compile gdbserver/tdesc.c to tdesc.o, common/tdesc.c to common/tdesc.o in gdbserver build directory. > >> > My next set of patches will then add common/tdesc.c. >> > This is slightly more tricky because we now build two tdesc.o files. >> >> I am inclined to create common/ directory in gdb and gdbserver build >> tree, and put the object files in the right directory. > > Yao, what do you mean with this? There already is a common/ directory wi= th > code shared by gdb and gdbserver. The thing is that tdesc.h was in arch/= not > in common/. Alan, Omair (if I recall right) and I agreed that it would be > better to move it to common/ because arch/ should only contain architectu= re > specific code. Or am I understanding you wrong? > It is build tree, instead of source tree. What I want is to have common/ i= n gdb and gdbserver build directory respectively. I am not against moving arch/tdesc.h to common/tdesc.h. --=20 Yao (=E9=BD=90=E5=B0=A7)