From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50468 invoked by alias); 9 May 2017 10:17:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50457 invoked by uid 89); 9 May 2017 10:17:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f180.google.com Received: from mail-qt0-f180.google.com (HELO mail-qt0-f180.google.com) (209.85.216.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 May 2017 10:17:24 +0000 Received: by mail-qt0-f180.google.com with SMTP id t26so55774665qtg.0 for ; Tue, 09 May 2017 03:17:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dxNJ5ZPlDlaTeeQ7B1OaQ9vN+SEu+4kkeDWaDlu3zSM=; b=LvtI8fM57p8dXRtX+lM02sbFC4kCe6I2xbnUHnjjn2Y1eZ5yNC91I8Tcwu3pRYptUA aDWBRG6RrCY1o9dGoIXhwUgkkwIidNsqirVHcFTg8vX/L0R3k/EFKBCaB8ChBeSi2Xys Fb3emn/1uf4/mh2gyd6xhNXWNX2Fatcq7E6fzO+oWdQPS4/ygFJ4iiWwP3NdbYA4HA6W 4Tsl4no8S8pFHyDBDd0i5EoxOxS2qK+uALj1sFA0UyfSuPfKKhNVBx6xP7p6pDnOIhZX B/QwccZ4vKF+CQg8el0np0E6LJ+1sX9CvL1OEZWXBqR7pZ7olrWMkd60mtqn3obsFPoq HbYA== X-Gm-Message-State: AN3rC/4U9OzX0skflQEk/AW2mqnREahUJ9eRONWLPpogXOB0Iyod4Zqo ci/nkFReZ4+f5RQ5MDvf0ISyTr3PT4Em X-Received: by 10.200.56.56 with SMTP id q53mr26402069qtb.36.1494325046014; Tue, 09 May 2017 03:17:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.140.76 with HTTP; Tue, 9 May 2017 03:17:25 -0700 (PDT) In-Reply-To: <83mvancrze.fsf@gnu.org> References: <20170504194442.63AAF60B72@joel.gnat.com> <83mvancrze.fsf@gnu.org> From: Yao Qi Date: Tue, 09 May 2017 10:17:00 -0000 Message-ID: Subject: Re: GDB 7.99.91 MinGW compilation warning in tui.c To: Eli Zaretskii Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00205.txt.bz2 On Mon, May 8, 2017 at 4:01 PM, Eli Zaretskii wrote: > tui/tui.c: In function 'void tui_enable()': > tui/tui.c:430:39: warning: ISO C++ forbids converting a string con= stant to 'char*' [-Wwrite-strings] > s =3D newterm ("unknown", stdout, stdin); > ^ > I fixed this by explicitly casting "unknown" to 'char *' -- is that > the right fix? Is it OK to push that fix? > Yes, I think so, we've done this before https://sourceware.org/ml/gdb-patches/2017-04/msg00032.html --=20 Yao (=E9=BD=90=E5=B0=A7)