From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5252 invoked by alias); 13 Jun 2016 10:47:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5131 invoked by uid 89); 13 Jun 2016 10:47:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=jhbfreebsdorg, jhb@freebsd.org, U*jhb, tgt_type X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-oi0-f46.google.com Received: from mail-oi0-f46.google.com (HELO mail-oi0-f46.google.com) (209.85.218.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 13 Jun 2016 10:47:37 +0000 Received: by mail-oi0-f46.google.com with SMTP id d132so97729004oig.1; Mon, 13 Jun 2016 03:47:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4PMpCfRj7RdTgB8JNcLW2Rp3zPVQ05wwFzTEx8324qQ=; b=mIk+8zwa7z1PzqAXawMPpqNIWApjamqSkI7w0EBTTOCs+TjRWdUypRZd6hRdzxaEzu 9FsNED5VrOVKm67cpeBOuGc4hewrtXBZ2qma/a+NINgSXX+rpU2z6NqUQUeNpsPFH0Nu J+sJQhENcaB58jhmjN6pbMpVQl0mYTatbyZNEXMW1G1qe0zkUiY+icvdNhnSRf98lW32 Uc4vRnhUgXxIZlMJOWh1pBFIXKVYJTZGTliFHzWaXjqMQdwC1VLEbOJ250LTNferLzxx y8deL6hE5nu4jFtWwlYPK6OjWOGDKCTdqVBivmorUta7Ho+EKkaffhkH75cubD2wG0yC tZ3A== X-Gm-Message-State: ALyK8tL8vc9KHodnkTWHioDV0OD0o2rMlq7lqhsJPK/3yTRqPfYWzKxZh4AXslosJUPZ7/lyli9w3meG7+CaRg== X-Received: by 10.157.36.98 with SMTP id p89mr7418776ota.119.1465814855608; Mon, 13 Jun 2016 03:47:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.68.4 with HTTP; Mon, 13 Jun 2016 03:47:35 -0700 (PDT) In-Reply-To: <1465678115-58170-8-git-send-email-jhb@FreeBSD.org> References: <1465678115-58170-1-git-send-email-jhb@FreeBSD.org> <1465678115-58170-8-git-send-email-jhb@FreeBSD.org> From: Yao Qi Date: Mon, 13 Jun 2016 10:47:00 -0000 Message-ID: Subject: Re: [PATCH 7/8] Remove unneeded checks on type lengths. To: John Baldwin Cc: "gdb-patches@sourceware.org" , binutils@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00219.txt.bz2 On Sat, Jun 11, 2016 at 9:48 PM, John Baldwin wrote: > Type lengths are unsigned, so are always greater than zero. A check The type length can be zero. > against the length of 'tgt_type' is retained to prevent dividing by zero. Your patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)