From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30556 invoked by alias); 3 Nov 2014 14:35:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30526 invoked by uid 89); 3 Nov 2014 14:35:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f45.google.com Received: from mail-oi0-f45.google.com (HELO mail-oi0-f45.google.com) (209.85.218.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 03 Nov 2014 14:35:47 +0000 Received: by mail-oi0-f45.google.com with SMTP id v63so5364175oia.32 for ; Mon, 03 Nov 2014 06:35:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=cYFiC74YOJURHs5T66PhOM9XVtHphda8Qe0gPFVkYtk=; b=VgmPdSFL8r9raTmoc4j2NjV01R12wuWNuDvmbG4AsjYhGTGu9NIRxkzjCwnYV61/74 48wJd+WaxfVHmOMy+w8F6Dezuc3xh9cO8NDnIkfIgArOHBmqLCWlg25t9ytEC3G/1COH Jfw3asloxw6gLyP8VvRaGto+BmUOyc7M1WO4Vd+LNOKQ3Fr7/LBQ0AF3PttIsUDqxkx0 lx2VcWL1Y20nmdn5DzwA0mzpjGmcl+TH1gGdf8TFUE4/WVbIoIIRGgWs/W+C2HWBUblk A0b4DVAC8G3dRfQI9c3+0uN9MJKMBmF7+D+DvztWnD0s7a+kF7qsEngXBFyHZ7yYN+vP mNag== X-Gm-Message-State: ALoCoQkN17WqU7IplO81Ld6ydj4XUPbX39KToe+VzdClG+WpDF20ibAnxPYmvNVcnyZt/TY3fvgX MIME-Version: 1.0 X-Received: by 10.60.52.193 with SMTP id v1mr37417462oeo.19.1415025345516; Mon, 03 Nov 2014 06:35:45 -0800 (PST) Received: by 10.202.197.13 with HTTP; Mon, 3 Nov 2014 06:35:45 -0800 (PST) In-Reply-To: References: Date: Mon, 03 Nov 2014 14:35:00 -0000 Message-ID: Subject: Re: [PATCH v4] Make chained function calls in expressions work From: Siva Chandra To: gdb-patches , Ulrich Weigand Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00044.txt.bz2 On Sat, Oct 25, 2014 at 7:24 AM, Siva Chandra wrote: > This is a follow up to the thread here: > https://sourceware.org/ml/gdb-patches/2014-10/msg00000.html > > I have made all the suggested changes which now eliminates the need > for two patches in this set. The single patch is attached. > > gdb/ChangeLog: > > 2014-10-25 Siva Chandra Reddy > > * eval.c (evaluate_expression): Cleanup stack mirrors that might > have been created. > (add_value_to_expression_stack, skip_current_expression_stack): > New functions. > * expression.h (struct expression): New field > 'on_stack_temporaries_vec'. > * gdbtypes.c (class_or_union_p): New function. > * gdbtypes.h (class_or_union_p): Declare. > * infcall.c (call_function_by_hand): New argument EXP of type > struct expression *. Setup stack temporaries for return values of > class type. > (get_return_value_from_memory): New function. > * infcall.h (call_function_by_hand): Update signature and all > callers. > * valarith.c (value_x_binop): New argument EXP of type > struct expression *. > (value_x_unop): Likewise. > * value.c (write_value_to_memory): New function. > (value_fetch_lazy): Fix its description comment. > * value.h (add_value_to_expression_stack) > (skip_current_expression_stack, write_value_to_memory): Declare. > (value_x_binop, value_x_unop): Update signature and all callers. > > gdb/testsuite/ChangeLog: > > 2014-10-25 Siva Chandra Reddy > > * gdb.cp/chained-calls.cc: New file. > * gdb.cp/chained-calls.exp: New file. > * gdb.cp/smartp.exp: Remove KFAIL from c2->inta. Ping.