From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18662 invoked by alias); 5 Nov 2014 00:33:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18652 invoked by uid 89); 5 Nov 2014 00:33:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f48.google.com Received: from mail-oi0-f48.google.com (HELO mail-oi0-f48.google.com) (209.85.218.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 05 Nov 2014 00:33:03 +0000 Received: by mail-oi0-f48.google.com with SMTP id x69so11148865oia.21 for ; Tue, 04 Nov 2014 16:33:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=SU/HsZwBUe/gQiIXCGeT+S2VpcE6H0PxCy7xK7zBcho=; b=VCK6+WxQHziyWEInoeKYCXqzkP1heZLh6MYbNDPuc8pH/3yTcvPloRIsqDMadM8+N/ rJHn9v1GF5TgeIlTgeGXDGw935Cu3umiQlhFo4KQGWAPaB7k2PItEnuY2tfHRNSppUhE GeHe+xLaHkJU2SWyg2ih2+hwVOT2+SFuks44AaWqPwNyYLaPNCmt7M0HjfuwmzX5ah3p QrkhACusrccO+nY1l1qlQr3WGJ7EylzqUjqFgQrf58Td+F7NddQcBzJ/mC9Rm+AF7hvd +Sa3epvFp24TW2uXdCiy3RiO4XE13bLQSd+NuJKIBrig29Mor+oaG6fRXPCaRPGm7ymm 3xXQ== X-Gm-Message-State: ALoCoQkFx6zQ1tRMQkb6G+ezMi2ug6EbfJie4b+pF4zZkmhSbobKf5jK+r/+wq3v+eu33PfzSweK MIME-Version: 1.0 X-Received: by 10.182.210.232 with SMTP id mx8mr10388203obc.46.1415147582032; Tue, 04 Nov 2014 16:33:02 -0800 (PST) Received: by 10.202.137.1 with HTTP; Tue, 4 Nov 2014 16:33:01 -0800 (PST) In-Reply-To: <20141105002415.GG20070@bubble.grove.modra.org> References: <201411031508.sA3F815b024788@d06av02.portsmouth.uk.ibm.com> <20141105002415.GG20070@bubble.grove.modra.org> Date: Wed, 05 Nov 2014 00:33:00 -0000 Message-ID: Subject: Re: [PATCH] PR c++/17494 - Fix evaluation of method calls under EVAL_SKIP From: Siva Chandra To: Alan Modra Cc: Ulrich Weigand , gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00091.txt.bz2 Sorry if I am at fault. My compiler is gcc-4.8.2 and I do not see these errors. I will dig further as soon as I can (which is not likely until tomorrow). On Tue, Nov 4, 2014 at 4:24 PM, Alan Modra wrote: > On Mon, Nov 03, 2014 at 06:08:15PM -0800, Siva Chandra wrote: >> >> PR c++/17494 >> >> * eval.c (evaluate_subexp_standard): Evaluate the "object" and >> >> the method args also under EVAL_SKIP when evaluating method >> >> calls under EVAL_SKIP. >> >> Thanks for the review. Pushed: e0f52461c2467b6610391681fa27cd9b3c5def57 > > After this patch, when using gcc-4.9.1 and gcc-5.0 (20140911) I see > what looks to me to be nonsense errors (ie. I'd suspect a compiler > bug). Does anyone else see the same? Nothing special in configure > options, x86_64-linux. > > /src/binutils-gdb/gdb/eval.c: In function =E2=80=98evaluate_subexp_standa= rd=E2=80=99: > /src/binutils-gdb/gdb/eval.c:745:16: error: =E2=80=98ret=E2=80=99 may be = used uninitialized in this function [-Werror=3Dmaybe-uninitialized] > struct value *ret =3D NULL; > ^ > In file included from /src/binutils-gdb/gdb/common/common-defs.h:49:0, > from /src/binutils-gdb/gdb/defs.h:28, > from /src/binutils-gdb/gdb/eval.c:20: > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: error: =E2=80=98= buf=E2=80=99 may be used uninitialized in this function [-Werror=3Dmaybe-un= initialized] > SIGJMP_BUF *buf =3D \ > ^ > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: note: =E2=80=98b= uf=E2=80=99 was declared here > SIGJMP_BUF *buf =3D \ > ^ > /src/binutils-gdb/gdb/eval.c:747:2: note: in expansion of macro =E2=80=98= TRY_CATCH=E2=80=99 > TRY_CATCH (ex, RETURN_MASK_ERROR) > ^ > /src/binutils-gdb/gdb/eval.c:1429:19: error: =E2=80=98value=E2=80=99 may = be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] > struct value *value =3D NULL; > ^ > In file included from /src/binutils-gdb/gdb/common/common-defs.h:49:0, > from /src/binutils-gdb/gdb/defs.h:28, > from /src/binutils-gdb/gdb/eval.c:20: > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: error: =E2=80=98= buf=E2=80=99 may be used uninitialized in this function [-Werror=3Dmaybe-un= initialized] > SIGJMP_BUF *buf =3D \ > ^ > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: note: =E2=80=98b= uf=E2=80=99 was declared here > SIGJMP_BUF *buf =3D \ > ^ > /src/binutils-gdb/gdb/eval.c:1430:5: note: in expansion of macro =E2=80= =98TRY_CATCH=E2=80=99 > TRY_CATCH (except, RETURN_MASK_ERROR) > ^ > /src/binutils-gdb/gdb/eval.c:1846:18: error: =E2=80=98value=E2=80=99 may = be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] > struct value *value =3D NULL; > ^ > In file included from /src/binutils-gdb/gdb/common/common-defs.h:49:0, > from /src/binutils-gdb/gdb/defs.h:28, > from /src/binutils-gdb/gdb/eval.c:20: > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: error: =E2=80=98= buf=E2=80=99 may be used uninitialized in this function [-Werror=3Dmaybe-un= initialized] > SIGJMP_BUF *buf =3D \ > ^ > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: note: =E2=80=98b= uf=E2=80=99 was declared here > SIGJMP_BUF *buf =3D \ > ^ > /src/binutils-gdb/gdb/eval.c:1847:4: note: in expansion of macro =E2=80= =98TRY_CATCH=E2=80=99 > TRY_CATCH (except, RETURN_MASK_ERROR) > ^ > cc1: all warnings being treated as errors > > > -- > Alan Modra > Australia Development Lab, IBM