From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18915 invoked by alias); 16 Oct 2014 14:38:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18902 invoked by uid 89); 16 Oct 2014 14:38:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-oi0-f53.google.com Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Oct 2014 14:38:17 +0000 Received: by mail-oi0-f53.google.com with SMTP id v63so2793837oia.12 for ; Thu, 16 Oct 2014 07:38:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=kCIBzKZLBUvzZsSTPIjsJrArITgu+fF/6YMi70AkbOc=; b=UQZsI1sAKixDZFZUp9SW0wCUlTFtA+lHY28U/zJaH2m90/q2yo/LSl0Y6sJ9TX2qwm 0LNWqsaOFK2JGyp0ctRotrwaMCqqqZr8/7o2ZuMI+z/kL9MeqOyN7oLmefLHo4jc6VvO bw9Wox67zSH+AQpm2dt6EKoKY0AprhnJiblLzkdrJsrZp/yKAWLlvJBi2IHM468RlSZw MEAqeXnFMSrW8+GX2VLay+4GubqRKtV981xVLcGcbx9dRo/kwUd08gaLAir7qpsfnIy+ sSo7p1y9hY9eWsc4iKPaJkrfZple+Iul4i4Ye1k4+2ZGZuSK6QuImzXgufaYq4gvD6QF T4iw== X-Gm-Message-State: ALoCoQk0xto46PaHDMSHCYkFNQ2SC15qUXypGzWvIPQpwcH7jz+irVX8bWnmHQlT7hWgpQOkjbOc MIME-Version: 1.0 X-Received: by 10.202.104.210 with SMTP id o79mr1260964oik.41.1413470295352; Thu, 16 Oct 2014 07:38:15 -0700 (PDT) Received: by 10.202.197.13 with HTTP; Thu, 16 Oct 2014 07:38:15 -0700 (PDT) Date: Thu, 16 Oct 2014 14:38:00 -0000 Message-ID: Subject: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference From: Siva Chandra To: Doug Evans , gdb-patches Content-Type: multipart/mixed; boundary=001a114098a0db1c7305058b32d8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00424.txt.bz2 --001a114098a0db1c7305058b32d8 Content-Type: text/plain; charset=UTF-8 Content-length: 468 A call to TYPE_TARGET_TYPE was being done without checking if the type does have a target type. This was introduced by my commit: 82c48ac732edb0155288a93ef3dd39625ff2d2e1 The attached patch fixes it. This probably qualifies as an obvious fix, but just in case. 2014-10-16 Siva Chandra Reddy * gnu-v3-abi.c (gnuv3_pass_by_reference): Call TYPE_TARGET_TYPE on the arg type of a constructor only if it is of reference type. --001a114098a0db1c7305058b32d8 Content-Type: text/plain; charset=US-ASCII; name="gnuv3_pass_by_reference_v1.txt" Content-Disposition: attachment; filename="gnuv3_pass_by_reference_v1.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i1c7md4u0 Content-length: 1062 ZGlmZiAtLWdpdCBhL2dkYi9nbnUtdjMtYWJpLmMgYi9nZGIvZ251LXYzLWFi aS5jCmluZGV4IGE2YzZmOWYuLmI5NjBhYTMgMTAwNjQ0Ci0tLSBhL2dkYi9n bnUtdjMtYWJpLmMKKysrIGIvZ2RiL2dudS12My1hYmkuYwpAQCAtMTMyMCwx MyArMTMyMCwxNSBAQCBnbnV2M19wYXNzX2J5X3JlZmVyZW5jZSAoc3RydWN0 IHR5cGUgKnR5cGUpCiAJaWYgKFRZUEVfTkZJRUxEUyAoZmllbGR0eXBlKSA9 PSAyKQogCSAgewogCSAgICBzdHJ1Y3QgdHlwZSAqYXJnX3R5cGUgPSBUWVBF X0ZJRUxEX1RZUEUgKGZpZWxkdHlwZSwgMSk7Ci0JICAgIHN0cnVjdCB0eXBl ICphcmdfdGFyZ2V0X3R5cGU7CiAKLQkgICAgYXJnX3RhcmdldF90eXBlID0g Y2hlY2tfdHlwZWRlZiAoVFlQRV9UQVJHRVRfVFlQRSAoYXJnX3R5cGUpKTsK KwkgICAgaWYgKFRZUEVfQ09ERSAoYXJnX3R5cGUpID09IFRZUEVfQ09ERV9S RUYpCisJICAgICAgeworCQlzdHJ1Y3QgdHlwZSAqYXJnX3RhcmdldF90eXBl OwogCi0JICAgIGlmIChUWVBFX0NPREUgKGFyZ190eXBlKSA9PSBUWVBFX0NP REVfUkVGCi0JCSYmIGNsYXNzX3R5cGVzX3NhbWVfcCAoYXJnX3RhcmdldF90 eXBlLCB0eXBlKSkKLQkgICAgICByZXR1cm4gMTsKKwkgICAgICAgIGFyZ190 YXJnZXRfdHlwZSA9IGNoZWNrX3R5cGVkZWYgKFRZUEVfVEFSR0VUX1RZUEUg KGFyZ190eXBlKSk7CisJCWlmIChjbGFzc190eXBlc19zYW1lX3AgKGFyZ190 YXJnZXRfdHlwZSwgdHlwZSkpCisJCSAgcmV0dXJuIDE7CisJICAgICAgfQog CSAgfQogICAgICAgfQogCg== --001a114098a0db1c7305058b32d8--