From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26136 invoked by alias); 13 Jun 2012 07:24:52 -0000 Received: (qmail 26127 invoked by uid 22791); 13 Jun 2012 07:24:49 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 07:24:36 +0000 Received: by vbkv13 with SMTP id v13so276145vbk.0 for ; Wed, 13 Jun 2012 00:24:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=0OtRbu0W3qfsouRVO0Darp3FbeUwd0b88LP/0qxODsE=; b=gy0GAu7/4g0Q/IuszKDBmyXRg8fSJto/8VHNnTCDa0S7pxeIni4en+27qgeszX/uca 2/fSXLQmNUajBzx6/b572sLNVQ6cAKugVkOc3RWb5jDWpN6DMHzQibdi3TsDQghfxgcN RkQixQRzYAMk53dlUAkOSTXBP5nFEkAFcCFhj3SMB8aMQE+3hxsQ5N31CWX34VTbiSvM dFPtQYvpNzPRgGmhC0+85j/9VK90WkpYDDGm8/D1lgHxD59FQzQ4WVduBTS2g7YcJuoW OkSZLieJxURKl9yU8n5aqsUNnWkR1MQbwGp2Z9Lrjb+hzkztNv+y7mb0uAMqXLY/67jr pZ0Q== Received: by 10.220.8.15 with SMTP id f15mr16252034vcf.34.1339572275675; Wed, 13 Jun 2012 00:24:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.8.15 with SMTP id f15mr16252019vcf.34.1339572275289; Wed, 13 Jun 2012 00:24:35 -0700 (PDT) Received: by 10.52.89.116 with HTTP; Wed, 13 Jun 2012 00:24:35 -0700 (PDT) In-Reply-To: <83ehpkz574.fsf@gnu.org> References: <83ehpkz574.fsf@gnu.org> Date: Wed, 13 Jun 2012 07:24:00 -0000 Message-ID: Subject: Re: [RFC - Python Scripting] Add 'end' attribute to gdb.Symtab_and_line From: Siva Chandra To: Eli Zaretskii Cc: dje@google.com, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=bcaec54ee3ee9e9d9f04c25579f4 X-System-Of-Record: true X-Gm-Message-State: ALoCoQlZRVsH95InWLPZ0rnf4FwG7J42kUzDaeoUTtN/MlSfy+RWB7cMHKEKJDV04LpE3drsR31CbZksce2sXuvf6jX2jytJxFDUjjJfAw+10nl/m4lBlNEKmqHmW8kepEF0oe+loqBlD4wZfi8vvKa9doDcnTeECQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00388.txt.bz2 --bcaec54ee3ee9e9d9f04c25579f4 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 886 Thanks Eli. I have modified according to your suggestion. 2012-06-13 Siva Chandra Reddy New attribute 'end_pc' for gdb.Symtab_and_line. * NEWS (Python Scripting): Add entry about the new attribute. * python/py-symtab.c (salpy_get_end_pc): New function which implements the get method for the 'end_pc' attribute of gdb.Symtab_and_line. (sal_object_getset): Add entry for the 'end_pc' attribute. doc/ * gdb.texinfo (Symbol Tables In Python): Add description about the new 'end_pc' attribute of gdb.Symtab_and line. testsuite/ * gdb.python/py-symtab.exp: Add tests to test the new attribute 'end_pc' of gdb.Symtab_and_line. * gdb.python/py-symbol.c: Move break point comment to enable testing of gdb.Symtab_and_line.end_pc. Thanks, Siva Chandra --bcaec54ee3ee9e9d9f04c25579f4 Content-Type: text/plain; charset=US-ASCII; name="sal_end_patch_v3.txt" Content-Disposition: attachment; filename="sal_end_patch_v3.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h3e2q6cn0 Content-length: 5954 SW5kZXg6IE5FV1MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9zcmMvc3JjL2dkYi9ORVdTLHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjUyNwpkaWZmIC11IC1wIC1yMS41MjcgTkVXUwotLS0gTkVXUwk2IEp1biAy MDEyIDE4OjAzOjUzIC0wMDAwCTEuNTI3CisrKyBORVdTCTEzIEp1biAyMDEy IDA3OjIxOjEzIC0wMDAwCkBAIC02MCw2ICs2MCw5IEBACiAgICoqIE5ldyBm dW5jdGlvbiBnZGIuZmluZF9wY19saW5lIHdoaWNoIHJldHVybnMgdGhlIGdk Yi5TeW10YWJfYW5kX2xpbmUKICAgICAgb2JqZWN0IGFzc29jaWF0ZWQgd2l0 aCBhIFBDIHZhbHVlLgogCisgICoqIGdkYi5TeW10YWJfYW5kX2xpbmUgaGFz IG5ldyBhdHRyaWJ1dGUgJ2VuZF9wYycgd2hpY2ggaG9sZHMgdGhlIGVuZAor ICAgICBvZiB0aGUgYWRkcmVzcyByYW5nZSBvY2N1cGllZCBieSBjb2RlIGZv ciB0aGUgY3VycmVudCBzb3VyY2UgbGluZS4KKwogKiBHbyBsYW5ndWFnZSBz dXBwb3J0LgogICBHREIgbm93IHN1cHBvcnRzIGRlYnVnZ2luZyBwcm9ncmFt cyB3cml0dGVuIGluIHRoZSBHbyBwcm9ncmFtbWluZwogICBsYW5ndWFnZS4K SW5kZXg6IGRvYy9nZGIudGV4aW5mbwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2RvYy9nZGIudGV4aW5mbyx2 CnJldHJpZXZpbmcgcmV2aXNpb24gMS45NzQKZGlmZiAtdSAtcCAtcjEuOTc0 IGdkYi50ZXhpbmZvCi0tLSBkb2MvZ2RiLnRleGluZm8JOCBKdW4gMjAxMiAx MzowNTo1NSAtMDAwMAkxLjk3NAorKysgZG9jL2dkYi50ZXhpbmZvCTEzIEp1 biAyMDEyIDA3OjIxOjIxIC0wMDAwCkBAIC0yNTI2Miw2ICsyNTI2MiwxMSBA QCBJbmRpY2F0ZXMgdGhlIGN1cnJlbnQgcHJvZ3JhbSBjb3VudGVyIGFkCiB3 cml0YWJsZS4KIEBlbmQgZGVmdmFyCiAKK0BkZWZ2YXIgU3ltdGFiX2FuZF9s aW5lLmVuZF9wYworSW5kaWNhdGVzIHRoZSBlbmQgb2YgdGhlIGFkZHJlc3Mg cmFuZ2Ugb2NjdXBpZWQgYnkgY29kZSBmb3IgdGhlIGN1cnJlbnQKK3NvdXJj ZSBsaW5lLiAgVGhpcyBhdHRyaWJ1dGUgaXMgbm90IHdyaXRhYmxlLgorQGVu ZCBkZWZ2YXIKKwogQGRlZnZhciBTeW10YWJfYW5kX2xpbmUubGluZQogSW5k aWNhdGVzIHRoZSBjdXJyZW50IGxpbmUgbnVtYmVyIGZvciB0aGlzIG9iamVj dC4gIFRoaXMKIGF0dHJpYnV0ZSBpcyBub3Qgd3JpdGFibGUuCkluZGV4OiBw eXRob24vcHktc3ltdGFiLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9weXRob24vcHktc3ltdGFiLmMsdgpy ZXRyaWV2aW5nIHJldmlzaW9uIDEuOQpkaWZmIC11IC1wIC1yMS45IHB5LXN5 bXRhYi5jCi0tLSBweXRob24vcHktc3ltdGFiLmMJMyBNYXkgMjAxMiAwNzow NzoyNSAtMDAwMAkxLjkKKysrIHB5dGhvbi9weS1zeW10YWIuYwkxMyBKdW4g MjAxMiAwNzoyMToyMSAtMDAwMApAQCAtMjM3LDYgKzIzNywxOSBAQCBzYWxw eV9nZXRfcGMgKFB5T2JqZWN0ICpzZWxmLCB2b2lkICpjbG9zCiAgIHJldHVy biBnZGJfcHlfbG9uZ19mcm9tX3Vsb25nZXN0IChzYWwtPnBjKTsKIH0KIAor LyogSW1wbGVtZW50YXRpb24gb2YgdGhlIGdldCBtZXRob2QgZm9yIHRoZSAn ZW5kX3BjJyBhdHRyaWJ1dGUgb2YKKyAgIGdkYi5TeW10YWJfYW5kX2xpbmUu ICAqLworCitzdGF0aWMgUHlPYmplY3QgKgorc2FscHlfZ2V0X2VuZF9wYyAo UHlPYmplY3QgKnNlbGYsIHZvaWQgKmNsb3N1cmUpCit7CisgIHN0cnVjdCBz eW10YWJfYW5kX2xpbmUgKnNhbCA9IE5VTEw7CisKKyAgU0FMUFlfUkVRVUlS RV9WQUxJRCAoc2VsZiwgc2FsKTsKKworICByZXR1cm4gZ2RiX3B5X2xvbmdf ZnJvbV91bG9uZ2VzdCAoc2FsLT5lbmQgLSAxKTsKK30KKwogc3RhdGljIFB5 T2JqZWN0ICoKIHNhbHB5X2dldF9saW5lIChQeU9iamVjdCAqc2VsZiwgdm9p ZCAqY2xvc3VyZSkKIHsKQEAgLTU1Niw2ICs1NjksOCBAQCBzdGF0aWMgUHlU eXBlT2JqZWN0IHN5bXRhYl9vYmplY3RfdHlwZSA9CiBzdGF0aWMgUHlHZXRT ZXREZWYgc2FsX29iamVjdF9nZXRzZXRbXSA9IHsKICAgeyAic3ltdGFiIiwg c2FscHlfZ2V0X3N5bXRhYiwgTlVMTCwgIlN5bXRhYiBvYmplY3QuIiwgTlVM TCB9LAogICB7ICJwYyIsIHNhbHB5X2dldF9wYywgTlVMTCwgIlJldHVybiB0 aGUgc3ltdGFiX2FuZF9saW5lJ3MgcGMuIiwgTlVMTCB9LAorICB7ICJlbmRf cGMiLCBzYWxweV9nZXRfZW5kX3BjLCBOVUxMLAorICAgICJSZXR1cm4gdGhl IHN5bXRhYl9hbmRfbGluZSdzIGVuZCBwYy4iLCBOVUxMIH0sCiAgIHsgImxp bmUiLCBzYWxweV9nZXRfbGluZSwgTlVMTCwKICAgICAiUmV0dXJuIHRoZSBz eW10YWJfYW5kX2xpbmUncyBsaW5lLiIsIE5VTEwgfSwKICAge05VTEx9ICAv KiBTZW50aW5lbCAqLwpJbmRleDogdGVzdHN1aXRlL2dkYi5weXRob24vcHkt c3ltYm9sLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2 cy9zcmMvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1zeW1ib2wu Yyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS42CmRpZmYgLXUgLXAgLXIxLjYg cHktc3ltYm9sLmMKLS0tIHRlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LXN5bWJv bC5jCTMgTWF5IDIwMTIgMDc6MDc6MjYgLTAwMDAJMS42CisrKyB0ZXN0c3Vp dGUvZ2RiLnB5dGhvbi9weS1zeW1ib2wuYwkxMyBKdW4gMjAxMiAwNzoyMToy MiAtMDAwMApAQCAtNDAsOCArNDAsOCBAQCBpbnQgcXEgPSA3MjsJCQkvKiBs aW5lIG9mIHFxICovCiBpbnQgZnVuYyAoaW50IGFyZykKIHsKICAgaW50IGkg PSAyOwotICBpID0gaSAqIGFyZzsKLSAgcmV0dXJuIGFyZzsgLyogQmxvY2sg YnJlYWsgaGVyZS4gICovCisgIGkgPSBpICogYXJnOyAvKiBCbG9jayBicmVh ayBoZXJlLiAgKi8KKyAgcmV0dXJuIGFyZzsKIH0KIAogc3RydWN0IHNpbXBs ZV9zdHJ1Y3QKSW5kZXg6IHRlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LXN5bXRh Yi5leHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9z cmMvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1zeW10YWIuZXhw LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjkKZGlmZiAtdSAtcCAtcjEuOSBw eS1zeW10YWIuZXhwCi0tLSB0ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1zeW10 YWIuZXhwCTMgTWF5IDIwMTIgMDc6MDc6MjYgLTAwMDAJMS45CisrKyB0ZXN0 c3VpdGUvZ2RiLnB5dGhvbi9weS1zeW10YWIuZXhwCTEzIEp1biAyMDEyIDA3 OjIxOjIyIC0wMDAwCkBAIC01NCwxMCArNTQsMTMgQEAgZ2RiX3B5X3Rlc3Rf c2lsZW50X2NtZCAicHl0aG9uIHN0YXRpY19ibAogZ2RiX3B5X3Rlc3Rfc2ls ZW50X2NtZCAicHl0aG9uIGdsb2JhbF9zeW1ib2xzID0gXFtcXTsgc3RhdGlj X3N5bWJvbHMgPSBcW1xdIiAiU2V0IHVwIHN5bWJvbCBuYW1lIGxpc3RzIiAw CiBnZGJfcHlfdGVzdF9zaWxlbnRfY21kICJweXRob24gZm9yIHN5bSBpbiBn bG9iYWxfYmxvY2s6IGdsb2JhbF9zeW1ib2xzLmFwcGVuZChzeW0ubmFtZSki ICJHZXQgZ2xvYmFsIHN5bWJvbCBuYW1lcyIgMAogZ2RiX3B5X3Rlc3Rfc2ls ZW50X2NtZCAicHl0aG9uIGZvciBzeW0gaW4gc3RhdGljX2Jsb2NrOiBzdGF0 aWNfc3ltYm9scy5hcHBlbmQoc3ltLm5hbWUpIiAiR2V0IHN0YXRpYyBzeW1i b2wgbmFtZXMiIDAKK2dkYl9weV90ZXN0X3NpbGVudF9jbWQgInN0ZXAiICJT dGVwIHRvIHRoZSBuZXh0IGxpbmUiIDAKK2dkYl9weV90ZXN0X3NpbGVudF9j bWQgInB5dGhvbiBuZXdfcGMgPSBnZGIuc2VsZWN0ZWRfZnJhbWUoKS5maW5k X3NhbCgpLnBjIiAiR2V0IG5ldyBQQyIgMAogCiAjIFRlc3Qgc2FsLgogZ2Ri X3Rlc3QgInB5dGhvbiBwcmludCBzYWwuc3ltdGFiIiAiLipnZGIucHl0aG9u L3B5LXN5bWJvbC5jLioiICJUZXN0IHN5bXRhYiIKIGdkYl90ZXN0ICJweXRo b24gcHJpbnQgc2FsLnBjIiAiJHtkZWNpbWFsfSIgIlRlc3Qgc2FsLnBjIgor Z2RiX3Rlc3QgInB5dGhvbiBwcmludCBzYWwuZW5kX3BjID09IChuZXdfcGMg LSAxKSIgIlRydWUiICJUZXN0IHNhbC5lbmRfcGMiCiBnZGJfdGVzdCAicHl0 aG9uIHByaW50IHNhbC5saW5lIiAiJGxpbmVfbm8iICJUZXN0IHNhbC5saW5l IgogZ2RiX3Rlc3QgInB5dGhvbiBwcmludCBzYWwuaXNfdmFsaWQoKSIgIlRy dWUiICJUZXN0IHNhbC5pc192YWxpZCIKIAo= --bcaec54ee3ee9e9d9f04c25579f4--