From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20280 invoked by alias); 4 Jun 2014 18:05:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20270 invoked by uid 89); 4 Jun 2014 18:05:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f176.google.com Received: from mail-we0-f176.google.com (HELO mail-we0-f176.google.com) (74.125.82.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 04 Jun 2014 18:05:44 +0000 Received: by mail-we0-f176.google.com with SMTP id q59so8717578wes.21 for ; Wed, 04 Jun 2014 11:05:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=GuQc14eztsMRm4+zykdMKFEqnoMUrw5ndkP6hFTgQqY=; b=IoJpizMQdrKXFx+S54DtdQXO+nQaaG1sjb5pekMn9NqMup3jXBXdoHjqdOlML2986N GsScVhSeFbnVrGSeAecjVONPJfEFEU0RB24Bb7UvNzXkx8aQCljNd8ijlmFl30IaLN5c HPR6LX9MmA74YFvUoAErzRN07p4Z+Gc9djXC+QP5xe+8zzcqZY3W24SqlTCWWia/FxGa S1f1+K/TaYkNBq0NToU8D+fzEWR54SRkk60qCgjW1QnQgt/i03kpOv6l9d75npQlSea9 o1qcI9xjqBJDW43aEuQ0vcHd79SolNzcvr3WSpA4/moHByy75BIPjO7ARmEEnuaWiarS IBqw== X-Gm-Message-State: ALoCoQkfjMu+Q8960GlYH2Skck9gLg16NkCxsTGNihsqGu9/ztdCSIyCIg7Mxobi2bZZ/c+iIqhl MIME-Version: 1.0 X-Received: by 10.180.85.163 with SMTP id i3mr7892037wiz.14.1401905141565; Wed, 04 Jun 2014 11:05:41 -0700 (PDT) Received: by 10.217.51.7 with HTTP; Wed, 4 Jun 2014 11:05:40 -0700 (PDT) Date: Wed, 04 Jun 2014 18:05:00 -0000 Message-ID: Subject: [PATCH] Fix py-xmethods.c when compiled with -Werror against Python 2.4 From: Siva Chandra To: gdb-patches Cc: Doug Evans , uweigand@de.ibm.com Content-Type: multipart/mixed; boundary=f46d0444eb09f9074e04fb06796a X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00198.txt.bz2 --f46d0444eb09f9074e04fb06796a Content-Type: text/plain; charset=UTF-8 Content-length: 431 Does the attached patch fix the issue pointed out by Ulrich Weigand here: https://sourceware.org/ml/gdb-patches/2014-06/msg00169.html ChangeLog 2014-06-04 Siva Chandra Reddy * python/py-xmethods.c (invoke_match_method) (gdbpy_get_matching_xmethod_workers, gdbpy_get_xmethod_arg_types): Cast the second arg to PyObject_GetAttrString and PyObject_GetAttrString to char *. --f46d0444eb09f9074e04fb06796a Content-Type: text/plain; charset=US-ASCII; name="fix_xmethod_for_2_4.txt" Content-Disposition: attachment; filename="fix_xmethod_for_2_4.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hw0y21cc0 Content-length: 2628 ZGlmZiAtLWdpdCBhL2dkYi9weXRob24vcHkteG1ldGhvZHMuYyBiL2dkYi9w eXRob24vcHkteG1ldGhvZHMuYwppbmRleCAwMDYyYjJkLi41YmExNDZmIDEw MDY0NAotLS0gYS9nZGIvcHl0aG9uL3B5LXhtZXRob2RzLmMKKysrIGIvZ2Ri L3B5dGhvbi9weS14bWV0aG9kcy5jCkBAIC0xMDYsNyArMTA2LDcgQEAgaW52 b2tlX21hdGNoX21ldGhvZCAoUHlPYmplY3QgKm1hdGNoZXIsIFB5T2JqZWN0 ICpweV9vYmpfdHlwZSwKIAogICBjbGVhbnVwcyA9IG1ha2VfY2xlYW51cCAo bnVsbF9jbGVhbnVwLCBOVUxMKTsKIAotICBlbmFibGVkX2ZpZWxkID0gUHlP YmplY3RfR2V0QXR0clN0cmluZyAobWF0Y2hlciwgZW5hYmxlZF9maWVsZF9u YW1lKTsKKyAgZW5hYmxlZF9maWVsZCA9IFB5T2JqZWN0X0dldEF0dHJTdHJp bmcgKG1hdGNoZXIsIChjaGFyICopIGVuYWJsZWRfZmllbGRfbmFtZSk7CiAg IGlmIChlbmFibGVkX2ZpZWxkID09IE5VTEwpCiAgICAgewogICAgICAgZG9f Y2xlYW51cHMgKGNsZWFudXBzKTsKQEAgLTEyNyw3ICsxMjcsNyBAQCBpbnZv a2VfbWF0Y2hfbWV0aG9kIChQeU9iamVjdCAqbWF0Y2hlciwgUHlPYmplY3Qg KnB5X29ial90eXBlLAogICAgICAgUHlfUkVUVVJOX05PTkU7CiAgICAgfQog Ci0gIG1hdGNoX21ldGhvZCA9IFB5T2JqZWN0X0dldEF0dHJTdHJpbmcgKG1h dGNoZXIsIG1hdGNoX21ldGhvZF9uYW1lKTsKKyAgbWF0Y2hfbWV0aG9kID0g UHlPYmplY3RfR2V0QXR0clN0cmluZyAobWF0Y2hlciwgKGNoYXIgKikgbWF0 Y2hfbWV0aG9kX25hbWUpOwogICBpZiAobWF0Y2hfbWV0aG9kID09IE5VTEwp CiAgICAgewogICAgICAgZG9fY2xlYW51cHMgKGNsZWFudXBzKTsKQEAgLTI1 MiwxMyArMjUyLDEzIEBAIGdkYnB5X2dldF9tYXRjaGluZ194bWV0aG9kX3dv cmtlcnMKIAogICAvKiBHYXRoZXIgZGVidWcgbWV0aG9kIG1hdGNoZXJzIHJl Z2lzdGVyZWQgZ2xvYmFsbHkuICAqLwogICBpZiAoZ2RiX3B5dGhvbl9tb2R1 bGUgIT0gTlVMTAotICAgICAgJiYgUHlPYmplY3RfSGFzQXR0clN0cmluZyAo Z2RiX3B5dGhvbl9tb2R1bGUsIG1hdGNoZXJzX2F0dHJfc3RyKSkKKyAgICAg ICYmIFB5T2JqZWN0X0hhc0F0dHJTdHJpbmcgKGdkYl9weXRob25fbW9kdWxl LCAoY2hhciAqKSBtYXRjaGVyc19hdHRyX3N0cikpCiAgICAgewogICAgICAg UHlPYmplY3QgKmdkYl9tYXRjaGVyczsKICAgICAgIFB5T2JqZWN0ICp0ZW1w ID0gcHlfeG1ldGhvZF9tYXRjaGVyX2xpc3Q7CiAKICAgICAgIGdkYl9tYXRj aGVycyA9IFB5T2JqZWN0X0dldEF0dHJTdHJpbmcgKGdkYl9weXRob25fbW9k dWxlLAotCQkJCQkgICAgIG1hdGNoZXJzX2F0dHJfc3RyKTsKKwkJCQkJICAg ICAoY2hhciAqKSBtYXRjaGVyc19hdHRyX3N0cik7CiAgICAgICBpZiAoZ2Ri X21hdGNoZXJzICE9IE5VTEwpCiAJewogCSAgcHlfeG1ldGhvZF9tYXRjaGVy X2xpc3QgPSBQeVNlcXVlbmNlX0NvbmNhdCAodGVtcCwgZ2RiX21hdGNoZXJz KTsKQEAgLTM5MSw4ICszOTEsOCBAQCBnZGJweV9nZXRfeG1ldGhvZF9hcmdf dHlwZXMgKGNvbnN0IHN0cnVjdCBleHRlbnNpb25fbGFuZ3VhZ2VfZGVmbiAq ZXh0bGFuZywKIAogICBjbGVhbnVwcyA9IGVuc3VyZV9weXRob25fZW52IChn ZXRfY3VycmVudF9hcmNoICgpLCBjdXJyZW50X2xhbmd1YWdlKTsKIAotICBn ZXRfYXJnX3R5cGVzX21ldGhvZCA9ICBQeU9iamVjdF9HZXRBdHRyU3RyaW5n IChweV93b3JrZXIsCi0JCQkJCQkgIGdldF9hcmdfdHlwZXNfbWV0aG9kX25h bWUpOworICBnZXRfYXJnX3R5cGVzX21ldGhvZCA9IFB5T2JqZWN0X0dldEF0 dHJTdHJpbmcKKyAgICAocHlfd29ya2VyLCAoY2hhciAqKSBnZXRfYXJnX3R5 cGVzX21ldGhvZF9uYW1lKTsKICAgaWYgKGdldF9hcmdfdHlwZXNfbWV0aG9k ID09IE5VTEwpCiAgICAgewogICAgICAgZ2RicHlfcHJpbnRfc3RhY2sgKCk7 Cg== --f46d0444eb09f9074e04fb06796a--