From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20551 invoked by alias); 1 Jun 2012 19:57:18 -0000 Received: (qmail 20539 invoked by uid 22791); 1 Jun 2012 19:57:16 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qa0-f41.google.com (HELO mail-qa0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jun 2012 19:57:02 +0000 Received: by qabg27 with SMTP id g27so669996qab.0 for ; Fri, 01 Jun 2012 12:57:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=uQmF3EPxlnil0vKKV+EeKEL1JTcl1K6PPOxCH/8/2RE=; b=ohmPjmDENqJNL0zC/GwGhx7794GoP1MZuvO8IudDuA7B7YAkz90XjviyMUkU5rvs5/ ZFTEbnOwQV4ZZkn3mJEB0M1g0oDGJDNOV/b9xUQ0Xb9LVwESLxCgbiMEaml4MG4i+Y38 dm5CrDEVRB1hlZRprqEbqRCviQnFx+JaaRcdHPhDVoONNgybVPMcSX91Z4dfiKEIiJZI COBOl+hVr9Qu98D4pZls9jjnE8/j8e5fVMCGaKLwm3mncnyl5Dd3TgUM3T0y8vxB1mqP vhOarebv6UiUn9yz7gkiXHcCKnK8jvPquJcnQSVDv/QziBQkZCbzkTpFDrM0SFKguJSN HGiQ== Received: by 10.229.105.145 with SMTP id t17mr1264620qco.123.1338580621905; Fri, 01 Jun 2012 12:57:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.105.145 with SMTP id t17mr1264609qco.123.1338580621157; Fri, 01 Jun 2012 12:57:01 -0700 (PDT) Received: by 10.224.131.26 with HTTP; Fri, 1 Jun 2012 12:57:01 -0700 (PDT) In-Reply-To: References: Date: Fri, 01 Jun 2012 19:57:00 -0000 Message-ID: Subject: Re: [RFC - Python Scripting] Add 'end' attribute to gdb.Symtab_and_line From: Siva Chandra To: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQkGhy0VpDCmzsQqiK3xxJb7/ALAWhYALlhe0+fhGtWBT5fmrjRHiDI+8reeQJ4fBMoN7g26OqC1epokCtj9vcjXsFAoC2sJu2wcl//e3ylh/h2l79FLM0j01FgjDyp1ehZOWMDncXcYRh9rQGrdEDsjAPMHaQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00039.txt.bz2 ping! On Mon, May 21, 2012 at 2:10 PM, Siva Chandra wrot= e: > Attached is a patch which adds the 'end' attribute to > gdb.Symtab_and_line. =A0Essentially, it exposes the 'end' field of > 'struct symtab_and_line'. > > Though I have named the new attribute 'end' in the attached patch, I > would like to discuss this. =A0There is already an attribute 'pc' which > is described as "Indicates the current program counter address" in the > documentation. =A0I do not think this description is accurate: 'pc' is > actually the begin address of the program counter address range for > the current source line. =A0To indicate the right meaning of 'pc' and > the new 'end' attribute, should they be named 'start_pc' and 'end_pc' > respectively, at least in the python API? > > 2012-05-21 =A0Siva Chandra Reddy =A0 > > =A0 =A0 =A0 =A0New attribute 'end' for gdb.Symtab_and_line. > =A0 =A0 =A0 =A0* NEWS (Python Scripting): Add entry about the new attribu= te. > =A0 =A0 =A0 =A0* python/py-symtab.c (salpy_get_end): New function which > =A0 =A0 =A0 =A0implements the get method for the 'end' attribute of > =A0 =A0 =A0 =A0gdb.Symtab_and_line. > =A0 =A0 =A0 =A0(sal_object_getset): Add entry for the 'end' attribute. > > =A0 =A0 =A0 =A0doc/ > =A0 =A0 =A0 =A0* gdb.texinfo (Symbol Tables In Python): Add description a= bout > =A0 =A0 =A0 =A0the new 'end' attribute of gdb.Symtab_and line. > > =A0 =A0 =A0 =A0testsuite/ > =A0 =A0 =A0 =A0* gdb.python/py-symtab.exp: Add tests to test the new > attribute > =A0 =A0 =A0 =A0'end' of gdb.Symtab_and_line. > =A0 =A0 =A0 =A0* gdb.python/py-symbol.c: Move break point comment to enab= le > =A0 =A0 =A0 =A0testing of gdb.Symtab_and_line.end. > > Thanks, > Siva Chandra